Skip to content

fix: Properly import npm-registry-fetch in react-native-macos-init #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix: Properly import npm-registry-fetch in react-native-macos-init #2186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fa18ec
fix: Properly import `npm-registry-fetch` in `react-native-macos-init`
Saadnajmi Aug 30, 2024
5b8f9fa
Change files
Saadnajmi Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...27af1077-e8dd-498f-9813-622bd400487c.json → ...f8ea158b-582a-420c-8fb7-8a1f75eb2cbe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"type": "patch",
"comment": "Update for Yarn 3+",
"comment": "fix: Properly import `npm-registry-fetch` in `react-native-macos-init`",
"packageName": "react-native-macos-init",
"email": "sanajmi@microsoft.com",
"dependentChangeType": "patch"
Expand Down
3 changes: 1 addition & 2 deletions packages/react-native-macos-init/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ import * as validUrl from 'valid-url';
import * as prompts from 'prompts';
import * as findUp from 'find-up';
import * as chalk from 'chalk';
// @ts-ignore
import npmFetch from 'npm-registry';
import * as npmFetch from 'npm-registry-fetch';

const npmConfReg = execSync('npm config get registry').toString().trim();
const NPM_REGISTRY_URL = validUrl.isUri(npmConfReg)
Expand Down