Skip to content

feat(fabric): Make all Views layer-backed #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2025
Merged

feat(fabric): Make all Views layer-backed #2724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8600765
[fabric] Make RCTViewComponentView to be layer-backed by enabling wan…
shwanton Apr 27, 2024
45b6015
[upstream][paper] Fix crash when statically enabling wantsUpdateLayer…
Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react-native/React/Base/macOS/RCTUIKit.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ @implementation RCTUIView
BOOL _clipsToBounds;
BOOL _userInteractionEnabled;
BOOL _mouseDownCanMoveWindow;
BOOL _respondsToDisplayLayer;
}

+ (NSSet<NSString *> *)keyPathsForValuesAffectingValueForKey:(NSString *)key
Expand Down Expand Up @@ -158,6 +159,7 @@ @implementation RCTUIView
self->_userInteractionEnabled = YES;
self->_enableFocusRing = YES;
self->_mouseDownCanMoveWindow = YES;
self->_respondsToDisplayLayer = [self respondsToSelector:@selector(displayLayer:)];
}
return self;
}
Expand Down Expand Up @@ -259,7 +261,12 @@ - (void)updateLayer
// so it has to be reset from the view's NSColor ivar.
[layer setBackgroundColor:[_backgroundColor CGColor]];
}
[(id<CALayerDelegate>)self displayLayer:layer];

// In Fabric, wantsUpdateLayer is always enabled and doesn't guarantee that
// the instance has a displayLayer method.
if (_respondsToDisplayLayer) {
[(id<CALayerDelegate>)self displayLayer:layer];
}
}

- (void)drawRect:(CGRect)rect
Expand Down
5 changes: 5 additions & 0 deletions packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2025,6 +2025,11 @@ - (NSString *)componentViewName_DO_NOT_USE_THIS_IS_BROKEN
return RCTNSStringFromString([[self class] componentDescriptorProvider].name);
}

- (BOOL)wantsUpdateLayer
{
return YES;
}

@end

#ifdef __cplusplus
Expand Down
Loading