Improve RCTTestRunner reliability #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Several integration tests suffer from unreliability in CI (and locally) and it appears to be because images being loaded from the internet or even locally can still be pending when the test ends. Waiting in the test runner for the RCTImageLoader queue to dequeue improves reliability locally -- lets see if it works in CI.
Update: two runs with previously disabled tests re-enabled. It works.
Changelog
[iOS] [Fixed] - Improve RCTTestRunner reliability
Test Plan
Ran integration tests for macOS and iOS locally.
Microsoft Reviewers: Open in CodeFlow