Cherry Pick key view loop change into 0.62-stable #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update RCTCxxBridge.mm * Update RCTCxxBridge.mm * initial props * initial key loop standup * update props * podfile * Add a few refs * NextKeyView -> NextKeyViewTest * More stuff * commit local changes * rip * commit local WIP * WIP * Clean up code a but for debugging * Key view loop works on a second pass * Move code to componentDidMount, but I still need the console logs in onFocus... * Latest local changes * Taking Tomun's approach * Clean up code * More cleanup * more clean up * for chris * wip * wip * WIP to see the diff * Cleanup * More cleanup * I guess the onFocus hack is the way to go * Cleanup * Update tags * Fix flow checks * yarn lint check fix * comment out flipper * Uncomment Flipper. We should just fix the CI failure instead * Clean up example fix ifdefs * Remove prop from everyhing but View * More comments * Minor indent fix * Revert podifle changes * update podfile * lint fix Co-authored-by: Chris Hogan <chrishog@microsoft.com> Co-authored-by: HeyImChris <48299693+HeyImChris@users.noreply.github.com>
Saadnajmi
changed the title
harrieshin
approved these changes
May 24, 2021
HeyImChris
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks #769 into 0.62-stable