Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support layout/size changes coming from XAML (e.g. Expander gets expanded) and have it reflow through Yoga, we need a notification to be fired when the element's measure changes.
That notification doesn't exist but we can wrap the native XAML control in a custom Panel, where we can use the MeasureOverride override to mark the corresponding yoga node as dirty and trigger a Yoga re-layout.
However, the problem is that this panel would have its width/height set by the Yoga layout pass. As a result, XAML will not call MeasureOverride (if W/H are set, you don't need to be notified, you'll be that size!).
To work around that, we need a second outer panel, which gets the W/H set, and hosts the panel with the notification code:
the Width/Height in the outermost panel will be set by Yoga based on its desired size.
Microsoft Reviewers: Open in CodeFlow