Prevent race condition in ConnectSucceeds WS unit test#14405
Merged
Conversation
dannyvv
approved these changes
Mar 7, 2025
NikoAri
approved these changes
Mar 7, 2025
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Mar 7, 2025
* Prevent race condition in ConnectSucceeds * Change files
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Mar 7, 2025
* Prevent race condition in ConnectSucceeds * Change files
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Mar 7, 2025
* Prevent race condition in ConnectSucceeds * Change files
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Mar 7, 2025
* Prevent race condition in ConnectSucceeds * Change files
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Mar 7, 2025
* Prevent race condition in ConnectSucceeds * Change files
This was referenced Mar 7, 2025
JunielKatarn
added a commit
that referenced
this pull request
Mar 8, 2025
* Refactor WebSocket resource class (#14377) * Update Test Website JSON dependencies to .NET 8 * Implement WinRTWebSocketResource2 * Add /rnw/websockets/pong endpoint * Add /rnw/websockets/echo endpoint * Add WebSocketMultipleSendTest.js * Allow arbitrary incoming size in server-side WebSocketTest * Define runtime option WebSocket.ResourceV2 * Centralize ReceiveStringAsync in shared class WebSocketUtils * Implement WebSocketMultipleSendTest_ClientReceive * Prevent high CPU usage caused by WebSockets (test website) * Allows passing an explicit calling context to execute resource handlers (i.e. JavaScript queue / main queue). * Change files * Prevent race condition in ConnectSucceeds WS unit test (#14405) * Prevent race condition in ConnectSucceeds * Change files * Remove change file
JunielKatarn
added a commit
that referenced
this pull request
Mar 10, 2025
* Refactor WebSocket resource class (#14377) * Update Test Website JSON dependencies to .NET 8 * Implement WinRTWebSocketResource2 * Add /rnw/websockets/pong endpoint * Add /rnw/websockets/echo endpoint * Add WebSocketMultipleSendTest.js * Allow arbitrary incoming size in server-side WebSocketTest * Define runtime option WebSocket.ResourceV2 * Centralize ReceiveStringAsync in shared class WebSocketUtils * Implement WebSocketMultipleSendTest_ClientReceive * Prevent high CPU usage caused by WebSockets (test website) * Allows passing an explicit calling context to execute resource handlers (i.e. JavaScript queue / main queue). * Change files * Prevent race condition in ConnectSucceeds WS unit test (#14405) * Prevent race condition in ConnectSucceeds * Change files * Remove change file
JunielKatarn
added a commit
that referenced
this pull request
Mar 10, 2025
* Prevent race condition in ConnectSucceeds WS unit test (#14405) * Prevent race condition in ConnectSucceeds * Change files * Remove change file * Change files
JunielKatarn
added a commit
that referenced
this pull request
Mar 10, 2025
* Refactor WebSocket resource class (#14377) * Update Test Website JSON dependencies to .NET 8 * Implement WinRTWebSocketResource2 * Add /rnw/websockets/pong endpoint * Add /rnw/websockets/echo endpoint * Add WebSocketMultipleSendTest.js * Allow arbitrary incoming size in server-side WebSocketTest * Define runtime option WebSocket.ResourceV2 * Centralize ReceiveStringAsync in shared class WebSocketUtils * Implement WebSocketMultipleSendTest_ClientReceive * Prevent high CPU usage caused by WebSockets (test website) * Allows passing an explicit calling context to execute resource handlers (i.e. JavaScript queue / main queue). * Change files * Prevent race condition in ConnectSucceeds WS unit test (#14405) * Prevent race condition in ConnectSucceeds * Change files * Remove change file
JunielKatarn
added a commit
that referenced
this pull request
Mar 10, 2025
* Refactor WebSocket resource class (#14377) * Update Test Website JSON dependencies to .NET 8 * Implement WinRTWebSocketResource2 * Add /rnw/websockets/pong endpoint * Add /rnw/websockets/echo endpoint * Add WebSocketMultipleSendTest.js * Allow arbitrary incoming size in server-side WebSocketTest * Define runtime option WebSocket.ResourceV2 * Centralize ReceiveStringAsync in shared class WebSocketUtils * Implement WebSocketMultipleSendTest_ClientReceive * Prevent high CPU usage caused by WebSockets (test website) * Allows passing an explicit calling context to execute resource handlers (i.e. JavaScript queue / main queue). * Change files * Prevent race condition in ConnectSucceeds WS unit test (#14405) * Prevent race condition in ConnectSucceeds * Change files * Remove change file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix unstable test Microsoft::React::Test::WinRTWebSocketResourceUnitTest::ConnectSucceeds
Type of Change
Why
The addressed test fails intermittently on CI runs.
What
Drain/synchronize test DispatchQueue used to emulate the calling thread.
Microsoft Reviewers: Open in CodeFlow