-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Deprecate autolink functionality to copy useWinUI3 flags from react-native.config.js into ExperimentalFeatures.props #14761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… react-native.config.js Co-authored-by: anupriya13 <54227869+anupriya13@users.noreply.github.com>
|
@copilot run |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@copilot Completely remove the |
Co-authored-by: jonthysell <10852185+jonthysell@users.noreply.github.com>
I've completely removed the
The changes resulted in a net reduction of 260+ lines of code. The autolink functionality now focuses purely on generating autolink files for native modules without any XAML dialect management. Commit: 7ce01ee Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Summary
This PR removes the deprecated functionality in
ensureXAMLDialect()that alloweduseWinUI3values fromreact-native.config.jsto override values inExperimentalFeatures.props. This feature was confusing, unnecessary, and causing test failures.Background
The
ensureXAMLDialect()function previously had logic that:useWinUI3fromreact-native.config.jsExperimentalFeatures.propsThis behavior was problematic because:
Changes Made
Core Logic Changes
ensureXAMLDialect()function inautolinkWindows.ts:useWinUI3FromConfigvariable and related logicExperimentalFeatures.propsExperimentalFeatures.propsTest Updates
Removed failing tests in
autolink.test.ts:ensureXAMLDialect - useWinUI3=true in react-native.config.js, useWinUI3=false in ExperimentalFeatures.propsensureXAMLDialect - useWinUI3=false in react-native.config.js, useWinUI3=true in ExperimentalFeatures.propsRemoved broken test in
projectConfig.test.ts:Preserved Functionality
useWinUI3setting inreact-native.config.jsremains available for other uses (e.g., project generation)ExperimentalFeatures.propsvalues directlyImpact
useWinUI3usageTesting
The remaining tests verify that:
useWinUI3is not specified in config, the function usesExperimentalFeatures.propsvalues directlyUseWinUI3=trueandUseWinUI3=falsein project filesFixes #14601.