Fix support for --namespace on react-native-windows init for cpp#5145
Merged
dannyvv merged 4 commits intomicrosoft:masterfrom Jun 11, 2020
Merged
Fix support for --namespace on react-native-windows init for cpp#5145dannyvv merged 4 commits intomicrosoft:masterfrom
--namespace on react-native-windows init for cpp#5145dannyvv merged 4 commits intomicrosoft:masterfrom
Conversation
Member
Author
…t the name of the variable. Wishes for well known typed languages everywhere :)
NickGerleman
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
react-native-windows inittemplate generation had a bug where namespaces weren't properly accounted for in the cpp project.This PR takes the x86 slice of the init tests and forces the cpp and the cs language versions to have a namespace.
Microsoft Reviewers: Open in CodeFlow