Dont try to parseJson unless redbox error starts with {#5439
Merged
3 commits merged intomicrosoft:masterfrom Jul 8, 2020
Merged
Dont try to parseJson unless redbox error starts with {#54393 commits merged intomicrosoft:masterfrom
3 commits merged intomicrosoft:masterfrom
Conversation
asklar
reviewed
Jul 7, 2020
asklar
reviewed
Jul 7, 2020
asklar
approved these changes
Jul 7, 2020
acoates-ms
added
the
AutoMerge
|
Hello @acoates-ms! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 8 hours 44 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when we hit a redbox error that is just a plain string, an exception is thrown as we attempt to parse the string as JSON.
In addition to being an annoying exception that causes the debugger to break when you have break on exceptions on, it also can cause the app to crash depending on the string.
This change avoids the attempted parse unless the string starts with a {, which it will in the case of metro errors which is what the code is trying to determine.
Microsoft Reviewers: Open in CodeFlow