[RNTester] Fix tabIndex Example#8644
Merged
Merged
Conversation
NickGerleman
approved these changes
Sep 17, 2021
Contributor
NickGerleman
left a comment
There was a problem hiding this comment.
Consider explicitly setting "focusable".
History here is we used to have a prop "acceptsKeyboardFocus", and our own logic for whether a Touchable should be focusable by default. A focusable prop, with its own logic, was added upstream. This added the behavior that disabled, or Touchables missing callbacks are not focusable by default.
Contributor
Author
|
Looks like the checks are failing in TextViewManager, likely #8454 conflicting with other changes to that file since the checks on it last ran - working on a fix. |
chrisglein
pushed a commit
to chrisglein/react-native-windows
that referenced
this pull request
Sep 22, 2021
* make example functional * explicitly focusable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to test
tabIndex, a component must be focusable. In the keyboarding example page we use TouchableHighlight in the tabIndex example, this adds an onPress() function to those components to make them focusable and make the example functional.Microsoft Reviewers: Open in CodeFlow