[TS] Bind remaining web touch handlers#1082
Merged
erictraut merged 3 commits intomicrosoft:masterfrom Apr 25, 2019
Merged
Conversation
dagatsoin
force-pushed
the
fix/bind-other-web-touch-handlers
branch
from
5970056 to
30cd070
Compare
dagatsoin
changed the title
Contributor
Author
|
Branch updated @erictraut There is a test in ButtonTest file if needed. |
erictraut
reviewed
Apr 21, 2019
Contributor
erictraut
left a comment
erictraut
left a comment
There was a problem hiding this comment.
Looks good to me. Just one place where your changes intersected some other changes I made recently. Please update that, and I'll merge. Thanks again for the contribution!
|
|
||
| // Touch has left the button, cancel the longpress handler. | ||
| if (this._isMouseOver && this._longPressTimer) { | ||
| Timers.clearTimeout(this._longPressTimer); |
Contributor
There was a problem hiding this comment.
Looks like a merge conflict occurred here. I recently updated all of the reactxp code to use Timers.clearTimeout consistently.
Contributor
|
Thanks again for the contribution! Merged. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1083
Following PR #1079
This PR does the following