Node reconciler indefinitely logs "Added Node .."

[SRodi]

Description

Testing retina v0.0.28 on GKE and the agent logs shows the following

...
ts=2025-03-20T16:55:05.524Z level=info caller=apiserver/apiserver.go:118 msg="New Apiserver IPs:" ip=34.118.224.1
time="2025-03-20T16:55:05Z" level=info msg="Added API server IPs to ipcache" IP=34.118.224.1 subsys=k8s-watcher
time="2025-03-20T16:55:35Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-dca54c7a-6sz9 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T16:59:23Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-3a3c21b9-61j3 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T16:59:31Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-5eb401cc-6mn1 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T16:59:33Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-dca54c7a-6sz9 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T16:59:37Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-5eb401cc-6mn1 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:00:00Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-3a3c21b9-61j3 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:00:41Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-dca54c7a-6sz9 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:02:33Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-dca54c7a-6sz9 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:04:24Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-3a3c21b9-61j3 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:04:32Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-5eb401cc-6mn1 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:04:33Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-dca54c7a-6sz9 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:04:44Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-5eb401cc-6mn1 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:05:07Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-3a3c21b9-61j3 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:07:39Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-dca54c7a-6sz9 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:09:24Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-3a3c21b9-61j3 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:09:33Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-5eb401cc-6mn1 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:09:34Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-dca54c7a-6sz9 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:09:52Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-5eb401cc-6mn1 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:10:13Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-3a3c21b9-61j3 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:12:45Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-dca54c7a-6sz9 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:14:24Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-3a3c21b9-61j3 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:14:34Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-dca54c7a-6sz9 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:14:34Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-5eb401cc-6mn1 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:14:58Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-5eb401cc-6mn1 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:15:20Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-3a3c21b9-61j3 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:17:50Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-dca54c7a-6sz9 <nil>}" component=node-controller subsys=node-controller
time="2025-03-20T17:19:25Z" level=info msg="Added Node{Node 15 0 gke-mc-gke-cluster-mc-node-pool-3a3c21b9-61j3 <nil>}" component=node-controller subsys=node-controller
...

The issue is with the logging within the daemon nodereconciler

retina/pkg/controllers/daemon/nodereconciler/node_controller_linux.go

Line 118 in eeb80e9

r.l.Info("Added Node", zap.String("Node", node.Name))

Fix

The log level should be changed to Debug

[nddq]

saw this issue before, i think we need to fix how the current node controller works

I think we should only filter for create and delete events