Skip to content

fix(ci): reorder buildx setup before GHCR login in kapinger workflow#2142

Merged
nddq merged 1 commit intomainfrom
fix/kapinger-buildx-order
Apr 13, 2026
Merged

fix(ci): reorder buildx setup before GHCR login in kapinger workflow#2142
nddq merged 1 commit intomainfrom
fix/kapinger-buildx-order

Conversation

@nddq
Copy link
Copy Markdown
Member

@nddq nddq commented Mar 27, 2026

Description

Currently, docker login ghcr.io runs before docker/setup-buildx-action in
all kapinger workflow jobs. When buildx bootstraps, it pulls
moby/buildkit:buildx-stable-1 from Docker Hub — but the prior GHCR login
poisons the Docker credential store, causing a 401 against registry-1.docker.io.

This PR reorders all 4 jobs (build-linux, build-windows, manifest,
build-toolbox) to run Set up Docker Buildx before Log in to GHCR, so
buildx can pull its builder image from Docker Hub with no credentials configured.

Failed run: https://github.com/microsoft/retina/actions/runs/23654791759/job/68908997696

Related Issue

N/A

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary. (not applicable — CI-only change)
  • I have added tests, if applicable. (not applicable — CI-only change)

Screenshots (if applicable) or Testing Completed

CI will validate — the workflow triggers on PRs that touch .github/workflows/kapinger.yaml.

Additional Notes

N/A

Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
@nddq nddq requested a review from a team as a code owner March 27, 2026 16:25
@github-actions
Copy link
Copy Markdown

Retina Code Coverage Report

Total coverage no change

@nddq nddq requested a review from ibezrukavyi March 27, 2026 17:15
@nddq nddq added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit b9d970b Apr 13, 2026
34 checks passed
@nddq nddq deleted the fix/kapinger-buildx-order branch April 13, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants