Merged
Conversation
juliaroldi
requested review from
Andres-CT98,
BryanValverdeU,
JiuqingSong,
flyingbee2012 and
ianeli1
JiuqingSong
reviewed
Sep 29, 2022
| const listIndex = trigger[trigger.length - 2]; | ||
|
|
||
| if (previousListChain) { | ||
| if (previousListChain && parseInt(listIndex) > 1) { |
Collaborator
There was a problem hiding this comment.
parseInt(listIndex) is also used in line 124, so save the result to a local var.
…t/roosterjs into u/juliaroldi/list-chain
JiuqingSong
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a list already exist on the editor and the triggers for start a new list (1), 1-, a., ...) is typed, there is no need to check if a list already exist. Just start a new list.