Allow Shift-Alt-<Left|Right> to indent/outdent list#1444
Merged
Conversation
JiuqingSong
reviewed
Nov 30, 2022
packages/roosterjs-editor-plugins/lib/plugins/ContentEdit/features/listFeatures.ts
Show resolved
Hide resolved
JiuqingSong
reviewed
Dec 1, 2022
packages/roosterjs-editor-plugins/lib/plugins/ContentEdit/features/listFeatures.ts
Show resolved
Hide resolved
JiuqingSong
reviewed
Dec 1, 2022
| ) => { | ||
| const isRTL = | ||
| event.rawEvent.keyCode !== Keys.TAB && | ||
| getComputedStyle(editor.getElementAtCursor(), 'direction') == 'rtl'; |
Collaborator
There was a problem hiding this comment.
getComputedStyle() is kind of heavy. So we should only call it when we really need to.
In this case, it means when we know that it is LEFT/RIGHT key with SHIFT key pressed, and there is list, then finally we can check if it is RTL. So that this function is only called when really need.
Member
Author
There was a problem hiding this comment.
Shift key check is handled by shouldHandleIndentationEvent, getComputedStyle doesn't get called if keycode is TAB, and this function is only called when shouldHandleIndentationEvent returns true, which already verifies if cursor is inside a list
JiuqingSong
approved these changes
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the following ContentEdit features from
listFeatures.ts:indentWhenTaboutdentWhenShiftTabInto a new
outdentIndentListItemfeature which also allows Shift-Alt-Right to perform the action of indenting and Shift-Alt-Left for outdenting