Skip to content

Demo site minor improvement #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JiuqingSong merged 3 commits into from
Jun 19, 2023
Merged

Demo site minor improvement #1895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7edb29
Demo site minor improvement
JiuqingSong Jun 18, 2023
292e577
improve
JiuqingSong Jun 18, 2023
cca3270
fix build
JiuqingSong Jun 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions demo/scripts/controls/sidePane/snapshot/SnapshotPane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const styles = require('./SnapshotPane.scss');

export interface SnapshotPaneProps {
onTakeSnapshot: () => Snapshot;
onRestoreSnapshot: (snapshot: Snapshot) => void;
onRestoreSnapshot: (snapshot: Snapshot, triggerContentChangedEvent: boolean) => void;
onMove: (moveStep: number) => void;
}

Expand Down Expand Up @@ -40,11 +40,14 @@ export default class SnapshotPane extends React.Component<SnapshotPaneProps, Sna
<button onClick={this.takeSnapshot}>{'Take snapshot'}</button>{' '}
<button
onClick={() =>
this.props.onRestoreSnapshot({
html: this.textarea.value,
metadata: null,
knownColors: [],
})
this.props.onRestoreSnapshot(
{
html: this.textarea.value,
metadata: null,
knownColors: [],
},
true
)
}>
{'Restore snapshot'}
</button>
Expand Down
9 changes: 4 additions & 5 deletions demo/scripts/controls/sidePane/snapshot/SnapshotPlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import * as React from 'react';
import SidePanePlugin from '../../SidePanePlugin';
import SnapshotPane from './SnapshotPane';
import UndoSnapshots from './UndoSnapshots';
import { ChangeSource, IEditor, PluginEvent, PluginEventType } from 'roosterjs-editor-types';
import { createSnapshots } from 'roosterjs-editor-dom';
import { IEditor, PluginEvent, PluginEventType } from 'roosterjs-editor-types';
import { Snapshot } from 'roosterjs-editor-types';

export default class SnapshotPlugin implements SidePanePlugin {
Expand Down Expand Up @@ -78,16 +78,15 @@ export default class SnapshotPlugin implements SidePanePlugin {

private onMove = (step: number) => {
const snapshot = this.snapshotService.move(step);
this.onRestoreSnapshot(snapshot);
this.onRestoreSnapshot(snapshot, false);
};

private onRestoreSnapshot = (snapshot: Snapshot) => {
private onRestoreSnapshot = (snapshot: Snapshot, triggerContentChangedEvent: boolean) => {
this.editorInstance.focus();
this.editorInstance.setContent(
this.component.snapshotToString(snapshot),
false /*triggerContentChangedEvent*/
triggerContentChangedEvent
);
this.editorInstance.triggerContentChangedEvent(ChangeSource.SetContent);
};

private updateSnapshots = () => {
Expand Down