Add size format handler to table cells#1896
Merged
BryanValverdeU merged 4 commits intomasterfrom Jun 20, 2023
Merged
Conversation
Collaborator
|
Does this have impact to table resize? e.g. paste a table that has width/height in TABLE element, then resize it, can it work well? |
…u/bvalverde/addSizeHandlerToCell
Contributor
Author
Checked again and it is working fine with Table Resize: |
BryanValverdeU
requested review from
Andres-CT98,
JiuqingSong,
flyingbee2012,
ianeli1 and
juliaroldi
JiuqingSong
approved these changes
Jun 20, 2023
BryanValverdeU
added a commit
that referenced
this pull request
Jun 20, 2023
* Add size handler to table cells * remove unrelated change
BryanValverdeU
added a commit
that referenced
this pull request
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last week we added table layout parser, but we also need to add size parser to table cells otherwise the table will not be rendered correctly. Eg:
Before:
After:
