Fix 212953: Do not delete entity when backspace from next table#1925
Merged
JiuqingSong merged 3 commits intomasterfrom Jun 30, 2023
Merged
Fix 212953: Do not delete entity when backspace from next table#1925JiuqingSong merged 3 commits intomasterfrom
JiuqingSong merged 3 commits intomasterfrom
Conversation
JiuqingSong
requested review from
Andres-CT98,
BryanValverdeU,
flyingbee2012,
ianeli1 and
juliaroldi
BryanValverdeU
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 212953: [Table][Loops]Loops will be deleted after clicking backspace in the first row and column on table
When backspace from a table next to an entity, we should only try to find entity within current region, but not delete anything outside the region. In this bug, current region will be a table cell, so any entity outside that table cell should not be impacted.