Couple of fixes for Word Online Paste#1965
Merged
BryanValverdeU merged 7 commits intomasterfrom Jul 21, 2023
Merged
Conversation
BryanValverdeU
requested review from
Andres-CT98,
JiuqingSong,
flyingbee2012,
ianeli1 and
juliaroldi
JiuqingSong
reviewed
Jul 20, 2023
| element: HTMLElement | ||
| ) => { | ||
| if (element.classList.contains(TABLE_CONTAINER) && element.style.marginLeft.startsWith('-')) { | ||
| element.style.marginLeft = '0px'; |
Collaborator
There was a problem hiding this comment.
I'm not sure if we should change this margin value here. Normally a parser should not modify source element.
Does it still work if we don't change the margin?
Contributor
Author
There was a problem hiding this comment.
You are right, I understand why this was not working. I should have been using the container formatParser instead of the block format parser.
Just removed this line
BryanValverdeU
changed the title
JiuqingSong
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, table container have negative margin in Word Online. Which causes the table to look truncated when pasted into rooster.
Remove that margin on paste when the source is Word Online
Before
After
Second bugfix is to keep the EOP Elements when pasting from Word Online since these elements can sometimes be present in new lines, and if we remove them can cause that the paste result will not have some new lines. (https://outlookweb.visualstudio.com/Outlook%20Web/_workitems/edit/218022/)