Do not enable paragraph map by default#2978
Merged
JiuqingSong merged 1 commit intomasterfrom Apr 7, 2025
Merged
Conversation
JiuqingSong
requested review from
BryanValverdeU,
flyingbee2012,
ianeli1,
juliaroldi and
vinguyen12
juliaroldi
approved these changes
Apr 7, 2025
juliaroldi
added a commit
that referenced
this pull request
Apr 7, 2025
* Support undeletable anchor Step 1: Support hidden properties (#2970) * Support undeletable anchor Step 1: Support hidden properties * improve comments * Support undeletable anchor Step 2: Add undeletable property to link (#2971) * Support undeletable anchor Step 1: Support hidden properties * Support undeletable anchor step 2 * improve comments * Support undeletable anchor Step 3: Support anchor (#2972) * Support undeletable anchor Step 1: Support hidden properties * Support undeletable anchor step 2 * improve comments * Support undeletable anchor Step 3 * Find previously marked paragraph (#2975) * Support undeletable anchor Step 4: Prevent deleting undeletable anchor (#2973) * Support undeletable anchor Step 1: Support hidden properties * Support undeletable anchor step 2 * improve comments * Support undeletable anchor Step 3 * Support undeletable anchor Step 4 * improve * add test * fix typo * Do not enable paragraph map by default (#2978) * Check selection for empty anchor (#2979) Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com> * fix test --------- Co-authored-by: Jiuqing Song <jisong@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a previous change (#2975 ) I added paragraph map feature. However I found that this has some side effect to test code that causes paragraph has a marker value which is order-sensitive. So in this change I'm adding an option for this feature and by default it is off.