Fix 341291: Enter key does not work after an inline entity under a list#2996
Merged
JiuqingSong merged 2 commits intomasterfrom Apr 14, 2025
Merged
Fix 341291: Enter key does not work after an inline entity under a list#2996JiuqingSong merged 2 commits intomasterfrom
JiuqingSong merged 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/roosterjs-content-model-core/lib/corePlugin/entity/entityDelimiterUtils.ts:341
- [nitpick] The change to use path[0] assumes that the first element of the path is always the intended parent block. Please verify that this index reliably represents the correct parent in all cases, and consider renaming the variable to reflect its specific role if needed.
selectionBlockParent = path[0];
BryanValverdeU
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
Press ENTER.
Expect: Go to next line and generate list item "2."
Actual: Nothing happens
This is in entityDelimiter code, it incorrectly retrieve the parent block using a wrong index.
Actually, when parent block group type is ListItem, we should not handle it since it will be handled by common enter handler code