Fix clipboard text handling for plain text pasting #3060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanValverdeU
requested review from
JiuqingSong,
Copilot,
flyingbee2012,
ianeli1,
juliaroldi and
vinguyen12
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the clipboard text handling for plain text pasting by ensuring that when no text is present in the clipboard data, the text content of the root element is used instead.
- Updated a test case to reflect the new behavior by expecting "HTML" instead of an empty string.
- Modified the createPasteFragment function to derive clipboard text from the root element when necessary.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/roosterjs-content-model-core/test/command/paste/createPasteFragmentTest.ts | Updated expected output for plain text pasting test |
| packages/roosterjs-content-model-core/lib/command/paste/createPasteFragment.ts | Added condition to set clipboardData.text from root.textContent |
packages/roosterjs-content-model-core/lib/command/paste/createPasteFragment.ts
Outdated
Show resolved
Hide resolved
…PasteFragment.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
juliaroldi
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no text in the clipboard data but here is html, get the text content of the root element and correctly set the text prop of the clipboard data,
Otherwise paste in this scenario would be no-op.
Fix 279830