[Image Edit] Image with borders #3155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
BryanValverdeU,
JiuqingSong,
flyingbee2012,
ianeli1 and
vinguyen12
JiuqingSong
approved these changes
Sep 18, 2025
JiuqingSong
added a commit
that referenced
this pull request
Sep 21, 2025
* add repositionTouchSelection handler * fix * define constant * fix * fix * revert previous PR change * add Touch Plugin * add repositionTouchSelection in Touch Plugin * small fix * add touch plugin to demo page * add comment * fix * export pointer event * add touchplugin test * reset pointerEvent to null after trigger action and settimeout to wait for updated cursor position * Remove tslint from recommended extension list (#3153) * default to end of the word if user tapped in the middle * add pointer event double click * handle selecting first space if selection is an open space with no word on right side * remove console.log * clearTimeout when dispose plugin * address Copilot comment * fix * Address comment * Lint code * handle the entire flow of touch selection, not rely on browser * remove test * move timeout and prevent default to within touch plugin, use doubleclick as general mouse event instead of pointer * address Copilot comments * add comment * fix comment * create const for regex * resuse getNodePositionFromEvent * remove unused change * fix issue with selection in middle of word * fix * address comments * Add comments * Remove auto-capitalizatio for first character * Remove Boolean() wrap * [Image Edit] Image with borders (#3155) recalculate the image wrapper size considering the border width * fix * remove word matching regex but using !space regex and !punctuation regex instead * fix version number --------- Co-authored-by: Vi Nguyen <nguyenvi@microsoft.com> Co-authored-by: Jiuqing Song <jisong@microsoft.com> Co-authored-by: Zander Wang <xiaozwan@microsoft.com> Co-authored-by: Haowen Chen <haowchen@microsoft.com> Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When image has borders, if rotate or resize the image wrapper was getting bigger incorrectly. Therefore, to fix this issue recalculate the image wrapper size considering the border width. Also do not resize the cloned image and the wrapper when rotating the image.
Before:
After:
