Filter out invisible unicode characters from text segments#3344
Merged
Conversation
BryanValverdeU
approved these changes
May 25, 2026
|
…mental feature Move the invisible unicode character stripping logic from createText (always-on) to addTextSegment, gated by the new 'FilterInvisibleUnicode' experimental feature. This ensures the behavior only activates when explicitly enabled via EditorOptions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
BryanValverdeU
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createTextso they cannot survive paste/DOM-to-model conversion. These characters are used to hide instructions/text inside HTML (see https://embracethered.com/blog/posts/2024/hiding-and-finding-text-with-unicode-tags/) and otherwise leak into the model as normal text.U+200B, ZWJU+200D, RLOU+202E, PDFU+202C) are preserved.creatorsTest.tscover mixed/boundary/only-invisible inputs and confirm meaningful invisible chars are untouched. An end-to-end test inendToEndTest.tsverifies a full DOM → Model → DOM/text round-trip strips only the tag range.Test plan
yarn test:fast --testPathPattern=creatorsTestyarn test:fast --testPathPattern=endToEndTest🤖 Generated with Claude Code