Clear whole list node stack when leaving its root parent#3357
Merged
Conversation
When handleBlockGroupChildren finishes processing a block group whose list node stack is rooted at the parent being left, clear the entire node stack instead of only its inner levels so a sibling block group does not incorrectly reuse the invalidated list element. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
BryanValverdeU
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the model-to-DOM list node stack could be incorrectly reused across sibling block groups.
When
handleBlockGroupChildrenfinishes processing a block group whose list node stack is rooted at the parent node being left (nodeStack[0].node === parent), the whole node stack is now cleared instead of only its inner levels. This prevents a subsequent sibling block group from reusing the now-invalidated list element.Changes
cleanUpNodeStacknow takes an optionalleavingParentargument. When it is the root of the node stack, the entire stack is popped.handleBlockGroupChildrenpasses theparentnode asleavingParentin the end-of-loop cleanup.Tests
Added two unit tests to
handleBlockGroupChildrenTest.ts:Both pass; the new behavior test fails against the previous code, confirming it guards the fix.
Original bug
https://outlookweb.visualstudio.com/Outlook%20Web/_workitems/edit/422204
🤖 Generated with Claude Code