[Rush] Rush install does not run pnpm install if common-versions.json changed and shrinkwrap not changed

[sunilsurana]

• [-] Bug

Issue description
We use dedicated build agents for our PR pipeline jobs so we don't clean the repo so that we save time doing npm install.

There are cases when shrinkwrap present on machine is not changed so rush skips running pnpm install command.

We had a case where common-versions.json was changed so rush skipped install and pr went thru fine. But the official build started failing because version specified in common-versions.json was not existing.

Expected Behaviour
Rush should include a way to check change in common-versions.json file also before skipping pnpm install

Extra note
This seems to be coming from here

[octogonz]

Extra note
This seems to be coming from here

That does look like a bug. I agree that we should add the common-versions.json path to the potentiallyChangedFiles list in that algorithm.

[octogonz]

@sunilsurana are you able to make a PR? Should be a fairly easy fix.

[sunilsurana]

PR for review @octogonz @iclanton
#1838

[iclanton]

This has been released in Rush 5.23.2.