[node-core-library] Gracefully handle irregular LockFile.tryAcquire fail on macOS/Linux#4497
Merged
iclanton merged 7 commits intomicrosoft:mainfrom Feb 7, 2024
andrew--r:feature/lockfile-handle-failure-gracefully
Merged
[node-core-library] Gracefully handle irregular LockFile.tryAcquire fail on macOS/Linux#4497iclanton merged 7 commits intomicrosoft:mainfrom andrew--r:feature/lockfile-handle-failure-gracefully
iclanton merged 7 commits intomicrosoft:mainfrom
andrew--r:feature/lockfile-handle-failure-gracefully
Conversation
…ail on macOS/Linux Fixes #4491
Contributor
Author
|
@microsoft-github-policy-service agree company="Joom Unipessoal LDA" |
…Handle for getting stats
iclanton
reviewed
Jan 30, 2024
Contributor
Author
|
I’ve dug a bit deeper into the problem, and I think I’ve managed to find the root cause. The problem occurs when at least two processes constantly try to acquire the same lock, e.g. when processing a task queue inside each process. Reproduction steps:
To be sure, in the next few days I’ll write some test cases covering this behaviour, and if it confirms, I’ll update the PR with a fix for the root cause. |
dmichon-msft
approved these changes
Feb 5, 2024
Contributor
Author
|
@iclanton could you please take a look at the updates when you’ll have time? |
iclanton
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4491
Summary and details
See #4497 (comment)
There are two fixes in this PR:
getStatisticsmethod toFileWriteras requestedHow it was tested
I’ve added a corresponding test case to LockFile tests suite