[rush-resolver-cache] Improve performance of scan for nested package.json files#5311
Merged
dmichon-msft merged 1 commit intomicrosoft:mainfrom Aug 20, 2025
Merged
Conversation
Improves performance of scanning for nested package.json files in packages.
dmichon-msft
requested review from
D4N14L,
apostolisms,
iclanton and
octogonz
as code owners
bmiddha
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves performance
@rushstack/rush-resolver-cache-pluginwhen scanning for nested package.json files in packages.Details
Skips the JSON parse and instead manually scans for the token
/package.json":, which marks the end of a file name key for a nested package.json file.How it was tested
Before:
After:
Manually verified that nested package.json entries were still found using some projects that were known to contain them.
Impacted documentation
None