[lockfile-explorer] Rewrite lockfile parser to be more correct #5363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eatePackageLockfileEntry()
…all the snapshots
octogonz
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
patmill
as code owners
| const rootRelativePath: Path | null = new Path('.').relative( | ||
| new Path(containingEntry.packageJsonFolderPath).concat(relativePath) | ||
| const rootRelativePath: string = lockfilePath.getAbsolute( | ||
| containingEntry.packageJsonFolderPath, |
Contributor
There was a problem hiding this comment.
At least as of pnpm@8, link: protocol paths are only resolved relative to the package.json section if encountered in importers:. If encountered in packages:, they are resolved relative to the pnpm workspace root.
Collaborator
Author
There was a problem hiding this comment.
Good catch. I guess those semantics are unavoidable, since the package.json folder location is nondeterministic.
Collaborator
Author
There was a problem hiding this comment.
Repro here: octogonz/lockfile-explorer-edge-cases@e586bbb
…fixes3 # Conflicts: # common/config/subspaces/default/repo-state.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Overhaul the lfxGraphLoader.ts, fixing a number of parser bugs in the process.
Details
@lifaon/pathdependency, replacing it with simple/fast handcoded functions. The key point is that we are manipulating well-behaved YAML strings, not actual filesystem paths.@pnpm/lockfile.types"."entryHow it was tested
Impacted documentation
None
@william2958 @iclanton