[webpack5-plugin]: try to use project-level dependency #5401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
aramissennyeydd
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
aramissennyeydd
commented
Oct 6, 2025
...hanges/@rushstack/heft-webpack5-plugin/sennyeya-fix-webpack-resolution_2025-10-06-19-00.json
Outdated
Show resolved
Hide resolved
…bpack-resolution_2025-10-06-19-00.json
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Contributor
|
Could you add a build test project to the repository that loads webpack from the project and has a fake webpack config that verifies that the version of "webpack" matches? You will likely either need to install a distinct version of webpack or have it be a link to a fake implementation that only has the bare minimum API. |
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Contributor
Author
|
@dmichon-msft I copied |
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
dmichon-msft
reviewed
Oct 6, 2025
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
iclanton
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows the webpack plugin to use the installed version of webpack in the project before resorting to the rig level one.
Details
Have been trying to add better enforcement of webpack dependencies to prevent phantom deps. Started running into issues with this line in webpack, https://github.com/webpack/webpack/blob/main/lib/NormalModule.js#L274-L278 where it expects a single instance of webpack to be used between the project and the rig running the project. If I install webpack directly at the project level, it will (sometimes) explode because the instances are no longer guaranteed to match.
How it was tested
Tested this change locally against our repo and saw a successful build. Let me know if I should add a build-tests for this, I either have to add a stale webpack version or add a contrived peer dependency resolution which seemed less than maintainable.
Impacted documentation