Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/lockfile-explorer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
"cors": "~2.8.5",
"express": "4.21.1",
"js-yaml": "~4.1.0",
"open": "~8.4.0",
"semver": "~7.7.4",
"update-notifier": "~5.1.0"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,20 @@

import process from 'node:process';
import * as path from 'node:path';
import type { ChildProcess } from 'node:child_process';

import express from 'express';
import yaml from 'js-yaml';
import cors from 'cors';
import open from 'open';
import updateNotifier from 'update-notifier';

import { FileSystem, type IPackageJson, JsonFile, PackageJsonLookup } from '@rushstack/node-core-library';
import {
Executable,
FileSystem,
type IPackageJson,
JsonFile,
PackageJsonLookup
} from '@rushstack/node-core-library';
import { ConsoleTerminalProvider, type ITerminal, Terminal, Colorize } from '@rushstack/terminal';
import {
type CommandLineFlagParameter,
Expand Down Expand Up @@ -251,8 +257,36 @@ export class ExplorerCommandLineParser extends CommandLineParser {

if (!appState.debugMode) {
try {
// Launch the web browser
await open(SERVICE_URL);
// Launch the default web browser using the platform-native open command.
let browserCmd: string;
let browserArgs: string[];
switch (process.platform) {
case 'win32': {
// "start" is a cmd.exe built-in, not a standalone executable.
// The empty string is the required [title] argument; without it,
// cmd interprets the URL as the title and ignores it.
browserCmd = 'cmd';
browserArgs = ['/c', 'start', '', SERVICE_URL];
break;
}

case 'darwin': {
browserCmd = 'open';
browserArgs = [SERVICE_URL];
break;
}

default: {
// Linux and other Unix-like systems
browserCmd = 'xdg-open';
browserArgs = [SERVICE_URL];
break;
}
}

const browserProcess: ChildProcess = Executable.spawn(browserCmd, browserArgs, { stdio: 'ignore' });
// Detach from our Node.js process so the browser stays open after we exit
browserProcess.unref();
} catch (e) {
this.globalTerminal.writeError('Error launching browser: ' + e.toString());
}
Expand Down
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/dependency-cleanup_2026-04-17.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Remove unused dependencies: replace `glob-escape` with `fast-glob`'s `escapePath`, replace `figures.pointer` with a named const, replace `builtin-modules` with `node:module.isBuiltin()`.",
"type": "patch"
}
],
"packageName": "@microsoft/rush"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@rushstack/heft-config-file",
"comment": "Remove `@ungap/structured-clone` polyfill; use native `structuredClone` (Node 18+).",
"type": "patch"
}
],
"packageName": "@rushstack/heft-config-file"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@rushstack/lockfile-explorer",
"comment": "Remove open dependency; use `Executable.spawn()` from `node-core-library` to launch the browser.",
"type": "patch"
}
],
"packageName": "@rushstack/lockfile-explorer"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@rushstack/npm-check-fork",
"comment": "Remove giturl dependency; replace with original toHttpsUrl() implementation using the native URL class.",
"type": "patch"
}
],
"packageName": "@rushstack/npm-check-fork"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@rushstack/rig-package",
"comment": "Replace `strip-json-comments` with `jju.parse()` for JSONC parsing.",
"type": "patch"
}
],
"packageName": "@rushstack/rig-package"
}
4 changes: 0 additions & 4 deletions common/config/rush/browser-approved-packages.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@
"name": "@rushstack/rush-vscode-command-webview",
"allowedCategories": [ "vscode-extensions" ]
},
{
"name": "@ungap/structured-clone",
"allowedCategories": [ "libraries" ]
},
{
"name": "axios",
"allowedCategories": [ "libraries" ]
Expand Down
24 changes: 0 additions & 24 deletions common/config/rush/nonbrowser-approved-packages.json
Original file line number Diff line number Diff line change
Expand Up @@ -602,10 +602,6 @@
"name": "babel-loader",
"allowedCategories": [ "tests" ]
},
{
"name": "builtin-modules",
"allowedCategories": [ "libraries" ]
},
{
"name": "buttono",
"allowedCategories": [ "tests" ]
Expand Down Expand Up @@ -710,10 +706,6 @@
"name": "fastify",
"allowedCategories": [ "tests" ]
},
{
"name": "figures",
"allowedCategories": [ "libraries" ]
},
{
"name": "file-loader",
"allowedCategories": [ "tests" ]
Expand All @@ -726,18 +718,10 @@
"name": "git-repo-info",
"allowedCategories": [ "libraries" ]
},
{
"name": "giturl",
"allowedCategories": [ "libraries" ]
},
{
"name": "glob",
"allowedCategories": [ "libraries", "vscode-extensions" ]
},
{
"name": "glob-escape",
"allowedCategories": [ "libraries" ]
},
{
"name": "heft-action-plugin",
"allowedCategories": [ "tests" ]
Expand Down Expand Up @@ -930,10 +914,6 @@
"name": "object-hash",
"allowedCategories": [ "libraries" ]
},
{
"name": "open",
"allowedCategories": [ "libraries" ]
},
{
"name": "package-extractor-test-02",
"allowedCategories": [ "tests" ]
Expand Down Expand Up @@ -1038,10 +1018,6 @@
"name": "string-argv",
"allowedCategories": [ "libraries" ]
},
{
"name": "strip-json-comments",
"allowedCategories": [ "libraries" ]
},
{
"name": "style-loader",
"allowedCategories": [ "libraries", "tests" ]
Expand Down
24 changes: 1 addition & 23 deletions common/config/subspaces/build-tests-subspace/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
{
"pnpmShrinkwrapHash": "72fae9b780cca1f45b7c807b24a587a13f1719e6",
"pnpmShrinkwrapHash": "1266218fdf9ed4d67e625f96e8c1cc4bae29dc68",
"preferredVersionsHash": "550b4cee0bef4e97db6c6aad726df5149d20e7d9",
"packageJsonInjectedDependenciesHash": "258293487508f4a9172933cb6d0c90a02599bd8d"
"packageJsonInjectedDependenciesHash": "0124f2d847733c92b17e06dd465a2c1e903c49d2"
}
Loading