fix: [rush] Parse pnpm-config.json with JsonSyntax.JsonWithComments#5820
Open
bartvandenende-wm wants to merge 1 commit into
Open
fix: [rush] Parse pnpm-config.json with JsonSyntax.JsonWithComments#5820bartvandenende-wm wants to merge 1 commit into
bartvandenende-wm wants to merge 1 commit into
Conversation
bartvandenende-wm
requested review from
apostolisms,
bmiddha,
dmichon-msft,
iclanton,
jxanthony and
octogonz
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5813.
ProjectChangeAnalyzerparses the currentpnpm-config.jsonwith a comment-tolerant loader, but parsed the historical git blob with strictJSON.parse. Any repo who uses the default pnpm config template shipped with rush fell into the "created or unparseable" branch on every diff — flagging every project as impacted and writing a diagnostic to stdout, which corruptsrush list --json --impacted-by.Details
Two small changes in
ProjectChangeAnalyzer._detectCatalogChangesAsync:JsonFile.parseString(...)from@rushstack/node-core-library, consistent with how the live file is loaded viaNonProjectConfigurationFile.terminal.writeWarningLine(stderr), matching the surrounding diagnostics in this file.How it was tested
Added one targeted regression test in
ProjectChangeAnalyzer.test.tsthat feeds the analyzer an oldpnpm-config.jsonblob containing//and/* */comments with catalogs identical to current, and asserts zero projects are flagged — pre-fix this would have parse-failed and flagged every catalog-using project.Impacted documentation
N/A