scalar should remove added git setting when un-registering

[hbinkle]

related to issue #446 scalar should remember which git setting it adds and remove them
or at least ask to remove them when un-registering.

[derrickstolee]

Thanks for the issue. I agree that we should be a bit better about this. The tricky part is that we don't know if any of these settings were already enabled before scalar register so we might be removing config the user really wants.

I see a couple ways forward:

1. scalar unregister --clear-config can be a way to force un-set all config options.
2. scalar unregister could check to see if any config settings match exactly what scalar register would have written then only un-set those. (This would remove config settings like core.multiPackIndex=true even if it was enabled before.)
3. scalar unregister could check only the most obscure config options and leave some that are marked as "safe":
   • Things like core.multiPackIndex=true and index.version=4 could be kept since they are well-established Git features.
   • Other more experimental things like status.aheadBehind or core.fsmonitor could be removed because they are unlikely to be set by users directly.

What do you think @hbinkle? Which of these options best matches your expectations?

[github-actions]

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.