test_prepare.py: Rename duplicate filename#13
Merged
Conversation
Renames `DefaultPk.bin` to `DefaultDbx.bin` due to the fact that using `DefaultPk.bin` and `DefaultPK.bin` would result in different file counts on Linux and Windows due to Linux treating files with different capitalizations as different files and windows not.
Switch to pull_request when running unit tests, so that tests are run against the actual changes in the codebase. Continue to use pull_request_target when performing a release.
makubacki
approved these changes
Oct 24, 2023
Flickdm
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
DefaultPk.bintoDefaultDbx.bindue to the fact that usingDefaultPk.binandDefaultPK.binwould result in different file counts on Linux and Windows due to Linux treating files with different capitalizations as different files and windows not.Updates to use pull_request rather than pull_request_target