Skip to content

Initial port of contents#4

Closed
Javagedes wants to merge 14 commits into
microsoft:mainfrom
Javagedes:initial-contents
Closed

Initial port of contents#4
Javagedes wants to merge 14 commits into
microsoft:mainfrom
Javagedes:initial-contents

Conversation

@Javagedes
Copy link
Copy Markdown
Contributor

@Javagedes Javagedes commented Aug 17, 2023

Performs an initial port of the project into the new repository. This port includes two scripts used to (1) generate the secure boot binaries for Intel and ARM architectures and (2) archive the binaries as .zip and .tar.gz files for each of the architectures.

Adds auxillary files for performing PR checks and automated attachment of the archive files to the release, if the workflow is being run due to the creation of a tag.

I have done verification of PR Checks and Asset loading on release on my personal fork: https://github.com/Javagedes/secureboot_objects/actions/runs/5893194292

update
Updates
Update
Performs an initial port of the project into the new repository. This
port includes two scripts used to (1) generate the secure boot binaries
for Intel and ARM architectures and (2) archive the binaries as .zip and
.tar.gz files for each of the architectures.

Adds auxillary files for performing PR checks and automated attachment
of the archive files to the release, if the workflow is being run due to
the creation of a tag.

Signed-off-by: Joey Vagedes <joeyvagedes@microsoft.com>
@spbrogan
Copy link
Copy Markdown
Member

I think your release names need to match the UEFI arch type you are expecting to use it on.
For example ARM, ARM64, IA32, X64. I assume Microsoft may only actively track for ARM64 and X64.

@Javagedes
Copy link
Copy Markdown
Contributor Author

I think your release names need to match the UEFI arch type you are expecting to use it on. For example ARM, ARM64, IA32, X64. I assume Microsoft may only actively track for ARM64 and X64.

@spbrogan I have added the changes so that release artifacts are based on architecture rather than family. Artifacts on release are now as follows:

image

Comment thread Readme.md

The secure boot binary objects are formatted to the expected EDKII data
structures to enable simple integration into any platform. Please refer to
[SecureBootKeyStoreLibOem](https://github.com/microsoft/mu_oem_sample/tree/release/202302/OemPkg/Library/SecureBootKeyStoreLibOem)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we are considering removing this library and directly consume this repo from platform level (i.e. integrate this into mu_tiano_platforms) once it is made public. So i think we probably do not want to refer to this instance here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flickdm Are we removing this library? I was under the impression that SecureBootKeyStoreLibOem would continue to be used, but updated to consume the pcds rather than the hard coded hex. And we would continue to use this library in mu_tiano_platforms.

@Flickdm Flickdm closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants