Bump uuid to 14.0.0 to fix GHSA-w5hq-g745-h8pq#251
Draft
Conversation
Agent-Logs-Url: https://github.com/microsoft/security-devops-action/sessions/d49d52e1-f745-4c75-916f-7d0eb45d9f4e Co-authored-by: DimaBir <28827735+DimaBir@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing buffer bounds check in uuid v3/v5/v6
Bump uuid to 14.0.0 to fix GHSA-w5hq-g745-h8pq
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot flagged
uuid@8.3.2(transitive via@microsoft/security-devops-actions-toolkit→@actions/io) for GHSA-w5hq-g745-h8pq:v3/v5/v6silently perform partial writes when given an undersizedbufor out-of-rangeoffsetinstead of throwingRangeErrorlikev1/v4/v7.Changes
package.json: added"uuid": ">=14.0.0"to the existingoverridesblock to force the transitive dep onto the patched line.package-lock.json/ bundlednode_modules/: regenerated vianpm install;node_modules/uuidnow resolves to14.0.0. (node_modules/is intentionally tracked in this repo since it ships as a GitHub Action.)Reachability Assessment
Not reachable — high confidence. No source under
src/,test/, orlib/importsuuid. The only consumer is@actions/io, which callsuuid.v4()(unaffected API, no caller-suppliedbuf) for temp directory names. The vulnerablev3/v5/v6code paths are never invoked, so this update is primarily to clear the scanner rather than to close an active exposure.Original prompt
This section details the Dependabot vulnerability alert you should resolve
<alert_title>uuid: Missing buffer bounds check in v3/v5/v6 when buf is provided</alert_title>
<alert_description>### Summary
v3,v5, andv6accept external output buffers but do not reject out-of-range writes (smallbufor largeoffset).By contrast,
v4,v1, andv7explicitly throwRangeErroron invalid bounds.This inconsistency allows silent partial writes into caller-provided buffers.
Affected code
src/v35.ts(v3/v5path) writesbuf[offset + i]without bounds validation.src/v6.tswritesbuf[offset + i]without bounds validation.Reproducible PoC
Observed:
v4 THREW RangeErrorv5 NO_THROWv6 NO_THROWExample partial overwrite evidence captured during audit:
Security impact
Suggested fix
Add the same guard used by
v4/v1/v7:Apply to:
src/v35.ts(coversv3andv5)src/v6.ts</alert_description>moderate
https://github.com/uuidjs/uuid/security/advisories/GHSA-w5hq-g745-h8pq https://github.com/uuidjs/uuid/commit/3d2c5b0342f0fcb52a5ac681c3d47c13e7444b34 https://github.com/uuidjs/uuid/releases/tag/v14.0.0 https://github.com/advisories/GHSA-w5hq-g745-h8pqGHSA-w5hq-g745-h8pq
uuid
npm
<vulnerable_versions>8.3.2</vulnerable_versions>
<patched_version>14.0.0</patched_version>
<manifest_path>package-lock.json</manifest_path>
<agent_instructions>Please fix this vulnerability</agent_instructions>
<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulner...