Skip to content

Bump uuid to 14.0.0 to fix GHSA-w5hq-g745-h8pq#251

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/fix-buffer-bounds-check
Draft

Bump uuid to 14.0.0 to fix GHSA-w5hq-g745-h8pq#251
Copilot wants to merge 2 commits intomainfrom
copilot/fix-buffer-bounds-check

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 24, 2026

Dependabot flagged uuid@8.3.2 (transitive via @microsoft/security-devops-actions-toolkit@actions/io) for GHSA-w5hq-g745-h8pq: v3/v5/v6 silently perform partial writes when given an undersized buf or out-of-range offset instead of throwing RangeError like v1/v4/v7.

Changes

  • package.json: added "uuid": ">=14.0.0" to the existing overrides block to force the transitive dep onto the patched line.
  • package-lock.json / bundled node_modules/: regenerated via npm install; node_modules/uuid now resolves to 14.0.0. (node_modules/ is intentionally tracked in this repo since it ships as a GitHub Action.)
"overrides": {
  ...
  "undici": ">=6.24.1",
  "uuid": ">=14.0.0"
}

Reachability Assessment

Not reachable — high confidence. No source under src/, test/, or lib/ imports uuid. The only consumer is @actions/io, which calls uuid.v4() (unaffected API, no caller-supplied buf) for temp directory names. The vulnerable v3/v5/v6 code paths are never invoked, so this update is primarily to clear the scanner rather than to close an active exposure.

Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>uuid: Missing buffer bounds check in v3/v5/v6 when buf is provided</alert_title>
<alert_description>### Summary

v3, v5, and v6 accept external output buffers but do not reject out-of-range writes (small buf or large offset).
By contrast, v4, v1, and v7 explicitly throw RangeError on invalid bounds.

This inconsistency allows silent partial writes into caller-provided buffers.

Affected code

  • src/v35.ts (v3/v5 path) writes buf[offset + i] without bounds validation.
  • src/v6.ts writes buf[offset + i] without bounds validation.

Reproducible PoC

cd /home/StrawHat/uuid
npm ci
npm run build

node --input-type=module -e "
import {v4,v5,v6} from './dist-node/index.js';
const ns='6ba7b810-9dad-11d1-80b4-00c04fd430c8';
for (const [name,fn] of [
  ['v4',()=>v4({},new Uint8Array(8),4)],
  ['v5',()=>v5('x',ns,new Uint8Array(8),4)],
  ['v6',()=>v6({},new Uint8Array(8),4)],
]) {
  try { fn(); console.log(name,'NO_THROW'); }
  catch(e){ console.log(name,'THREW',e.name); }
}"

Observed:

  • v4 THREW RangeError
  • v5 NO_THROW
  • v6 NO_THROW

Example partial overwrite evidence captured during audit:

same true buf [
  170, 170, 170, 170,
   75, 224, 100,  63
]
v6 [
  187, 187, 187, 187,
   31,  19, 185,  64
]

Security impact

  • Primary: integrity/robustness issue (silent partial output).
  • If an application assumes full UUID writes into preallocated buffers, this can produce malformed/truncated/partially stale identifiers without error.
  • In systems where caller-controlled offsets/buffer sizes are exposed indirectly, this may become a security-relevant logic flaw.

Suggested fix

Add the same guard used by v4/v1/v7:

if (offset < 0 || offset + 16 > buf.length) {
  throw new RangeError(`UUID byte range ${offset}:${offset + 15} is out of buffer bounds`);
}

Apply to:

  • src/v35.ts (covers v3 and v5)
  • src/v6.ts</alert_description>

moderate
GHSA-w5hq-g745-h8pq
uuid
npm
<vulnerable_versions>8.3.2</vulnerable_versions>
<patched_version>14.0.0</patched_version>
<manifest_path>package-lock.json</manifest_path>

https://github.com/uuidjs/uuid/security/advisories/GHSA-w5hq-g745-h8pq https://github.com/uuidjs/uuid/commit/3d2c5b0342f0fcb52a5ac681c3d47c13e7444b34 https://github.com/uuidjs/uuid/releases/tag/v14.0.0 https://github.com/advisories/GHSA-w5hq-g745-h8pq

<agent_instructions>Please fix this vulnerability</agent_instructions>

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulner...

Copilot AI changed the title [WIP] Fix missing buffer bounds check in uuid v3/v5/v6 Bump uuid to 14.0.0 to fix GHSA-w5hq-g745-h8pq Apr 24, 2026
Copilot AI requested a review from DimaBir April 24, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants