Python: honor reducer auto-reduce in chat completion threads#14017
Open
pragnyanramtha wants to merge 1 commit into
Open
Python: honor reducer auto-reduce in chat completion threads#14017pragnyanramtha wants to merge 1 commit into
pragnyanramtha wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #12303.
ChatHistoryAgentThreadcan be initialized with aChatHistoryReducer, but new thread messages were appended withadd_message(). That bypasses reduceradd_message_async()behavior, so reducers configured withauto_reduce=Truedo not reduce history as messages are added through the agent thread.Description
add_message_async()when the thread history is aChatHistoryReducerChatHistoryauto_reduce=Truereduces newly added thread messagesContribution Checklist
Validation
From
python/:uv run --python 3.12 pytest tests/unit/agents/chat_completion/test_chat_completion_agent.py -q-> 24 passeduv run --python 3.12 pytest tests/unit/contents/test_chat_history_truncation_reducer.py tests/unit/agents/chat_completion/test_chat_completion_agent.py -q-> 42 passeduv run ruff check semantic_kernel/agents/chat_completion/chat_completion_agent.py tests/unit/agents/chat_completion/test_chat_completion_agent.py-> passedgit diff --check-> passed