CopilotChat: Options pattern and best practices#588
Merged
adrianwyatt merged 38 commits intomicrosoft:mainfrom Apr 25, 2023
adrianwyatt:options
Merged
CopilotChat: Options pattern and best practices#588adrianwyatt merged 38 commits intomicrosoft:mainfrom adrianwyatt:options
adrianwyatt merged 38 commits intomicrosoft:mainfrom
adrianwyatt:options
Conversation
adrianwyatt
added
the
PR: in progress
adrianwyatt
added
PR: ready for review
glahaye
reviewed
Apr 21, 2023
glahaye
reviewed
Apr 21, 2023
glahaye
reviewed
Apr 21, 2023
glahaye
reviewed
Apr 21, 2023
glahaye
reviewed
Apr 21, 2023
glahaye
reviewed
Apr 21, 2023
glahaye
reviewed
Apr 21, 2023
glahaye
reviewed
Apr 21, 2023
glahaye
reviewed
Apr 21, 2023
glahaye
reviewed
Apr 21, 2023
glahaye
reviewed
Apr 21, 2023
Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
glahaye
previously approved these changes
Apr 24, 2023
glahaye
previously approved these changes
Apr 24, 2023
TaoChenOSU
previously approved these changes
Apr 24, 2023
TaoChenOSU
approved these changes
Apr 25, 2023
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context Aligning CopilotChat further down the path of a reference application. ### Description - Refactored configurations to use Options pattern as a best practice. - Moved to use Kestral appsettings for the endpoint and we now report the endpoint after the application starts, which will account for any configuration changes that may have occurred. - Moved web and service builder extensions to their own files to slim down `Program.cs` and make it easier to understand each set of extensions. This is mostly to separate out those extensions related to Semantic Kernel so developers can find those code sections more easily. - Renamed bot from "SK Chatbot" to "Copilot" to align with the project name.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context Aligning CopilotChat further down the path of a reference application. ### Description - Refactored configurations to use Options pattern as a best practice. - Moved to use Kestral appsettings for the endpoint and we now report the endpoint after the application starts, which will account for any configuration changes that may have occurred. - Moved web and service builder extensions to their own files to slim down `Program.cs` and make it easier to understand each set of extensions. This is mostly to separate out those extensions related to Semantic Kernel so developers can find those code sections more easily. - Renamed bot from "SK Chatbot" to "Copilot" to align with the project name.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context Aligning CopilotChat further down the path of a reference application. ### Description - Refactored configurations to use Options pattern as a best practice. - Moved to use Kestral appsettings for the endpoint and we now report the endpoint after the application starts, which will account for any configuration changes that may have occurred. - Moved web and service builder extensions to their own files to slim down `Program.cs` and make it easier to understand each set of extensions. This is mostly to separate out those extensions related to Semantic Kernel so developers can find those code sections more easily. - Renamed bot from "SK Chatbot" to "Copilot" to align with the project name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Aligning CopilotChat further down the path of a reference application.
Description
Program.csand make it easier to understand each set of extensions. This is mostly to separate out those extensions related to Semantic Kernel so developers can find those code sections more easily.