Change Pass::Run to take Program by value#100
Merged
Conversation
1ntEgr8
force-pushed
the
users/elton/client-free-shards
branch
from
fa6c1f6 to
80a1fa0
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
c35d43b to
fefa490
Compare
1ntEgr8
force-pushed
the
users/elton/client-free-shards
branch
from
80a1fa0 to
bd8191c
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
fefa490 to
7d5a2d3
Compare
1ntEgr8
force-pushed
the
users/elton/client-free-shards
branch
from
bd8191c to
f61e849
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
7d5a2d3 to
c3574bc
Compare
1ntEgr8
force-pushed
the
users/elton/client-free-shards
branch
from
f61e849 to
c75521d
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
c3574bc to
89357f1
Compare
1ntEgr8
force-pushed
the
users/elton/client-free-shards
branch
from
c75521d to
31ad691
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
89357f1 to
1d6a072
Compare
1ntEgr8
force-pushed
the
users/elton/client-free-shards
branch
from
31ad691 to
2a6923b
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
1d6a072 to
40c37ee
Compare
1ntEgr8
force-pushed
the
users/elton/client-free-shards
branch
from
2a6923b to
bdaf7d6
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
40c37ee to
6db5447
Compare
1ntEgr8
force-pushed
the
users/elton/client-free-shards
branch
from
bdaf7d6 to
2a6923b
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
6db5447 to
40c37ee
Compare
1ntEgr8
force-pushed
the
users/elton/client-free-shards
branch
from
2a6923b to
4f19fbd
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
40c37ee to
ab3f95b
Compare
1ntEgr8
force-pushed
the
users/elton/client-free-shards
branch
from
4f19fbd to
e635649
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
ab3f95b to
93f6338
Compare
1ntEgr8
force-pushed
the
users/elton/client-free-shards
branch
from
e635649 to
8e8dddb
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
93f6338 to
3ff07eb
Compare
Program is a move-only type, so passing by value enables callers to transfer ownership via std::move and allows passes to return early without cloning (e.g. the null-topology fast path just returns the input directly). Update PassManager to std::move programs between passes and adjust test fixtures to use factory lambdas for repeated program creation.
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
3ff07eb to
87d1e39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass::Runsignature to takeProgramby value instead of const reference