Move planning hints from global coordinator state to per-operation#101
Merged
Move planning hints from global coordinator state to per-operation#101
Conversation
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
c35d43b to
fefa490
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
from
4896fb0 to
43de7e1
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
fefa490 to
7d5a2d3
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
from
43de7e1 to
db244f0
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
7d5a2d3 to
c3574bc
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
from
db244f0 to
b285922
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
c3574bc to
89357f1
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
from
b285922 to
c8c2bb0
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
89357f1 to
1d6a072
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
from
c8c2bb0 to
36c02a2
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
1d6a072 to
40c37ee
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
from
36c02a2 to
5fe3eed
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
40c37ee to
6db5447
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
3 times, most recently
from
d47cf0a to
5fe3eed
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
2 times, most recently
from
40c37ee to
ab3f95b
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
from
5fe3eed to
c1688da
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
ab3f95b to
93f6338
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
from
c1688da to
b8e99db
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
93f6338 to
3ff07eb
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
from
b8e99db to
892f7f7
Compare
1ntEgr8
force-pushed
the
users/elton/pass-run-by-value
branch
from
3ff07eb to
87d1e39
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
from
892f7f7 to
11980d0
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
4 times, most recently
from
026a6d3 to
cd9634a
Compare
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
from
cd9634a to
f24fa2c
Compare
Instead of setting hints globally on the Coordinator (which requires coordinating hint state across operations), hints are now passed with each copy/pull submission. This makes the API stateless and allows different operations to use different routing strategies. Key changes: - Add hints parameter to SubmitCopyRequest and SubmitPullRequest - Add RoutingHint with serializable topology path - Update Client.copy() and Client.pull() to accept hints - Remove global add_hint/clear_hints from Coordinator pybind - Add Topology serialization support for hint transport - Extract Handler, Executor, Gateway, DispatchManager, and Types from monolithic Coordinator into separate files - DispatchManager encapsulates CopyKey as private implementation detail - Introduce ShardSubmission struct to reduce SubmitShard parameter count - Merge operation_hints_ and operation_fingerprints_ into single map - Add FinalizeAggregation to move post-completion bookkeeping into DispatchManager - Replace CancelPendingIf with CancelPendingByTensors public API - Assert on unknown copy_op_id in RecordResponse - Use std::visit for SubmitResult handling instead of std::get_if
1ntEgr8
force-pushed
the
users/elton/hints-per-operation
branch
from
f24fa2c to
4460768
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary