Conversation
There was a problem hiding this comment.
Pull request overview
Adds a documented and build-time mechanism to customize Docker trust (custom CA certs) and Python package installation behavior (pip.conf) for customer environments.
Changes:
- Copy
docker-customization/pip.confinto the builder image as/etc/pip.conffor pip configuration duringpip install. - Copy
docker-customization/custom-ca-certificates/into the system trust anchors and runupdate-ca-trustduring the build. - Add docs and release notes entry describing the customization workflow.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
application/single_app/Dockerfile |
Uses repo-root docker-customization/ inputs to configure pip and CA trust; adds runtime cert-related env vars. |
docker-customization/pip.conf |
Placeholder pip config file intended to be customized by deployers/customers. |
docs/how-to/docker_customization.md |
New how-to documentation for adding custom CA certs and pip.conf. |
docs/explanation/release_notes.md |
Adds a release note entry for Docker customization fixes. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Bionic711
left a comment
Bionic711
left a comment
There was a problem hiding this comment.
Fix the conflicts and we can merge.
| * **Docker Customization: CA Certificate and pip.conf** | ||
| * Fixed Docker customization issues related to custom CA certificate handling and `pip.conf` configuration. | ||
| * Ensures Python package installation works reliably in environments requiring custom certificate trust and pip configuration. | ||
| * (Ref: Docker customization, CA cert setup, `pip.conf` handling) | ||
|
|
There was a problem hiding this comment.
This PR changes build/runtime behavior (Dockerfile + new customization paths), but the version isn’t bumped and the release note is being added under the existing v0.239.005 section. Per the repo’s versioning instructions, please increment VERSION in application/single_app/config.py (third segment only) and add/move this release note under the new version header at the top of release_notes.md.
Ref: .github/instructions/update_version.instructions.md
Fix problems with customizing CA and pip.conf from testing in customer environment.