Added addr() implementation for pointer to TunnelIncoming #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamvamsikrishnad
requested review from
Copilot and
iamvamsikrishnad
and removed request for
iamvamsikrishnad
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where TunnelUplink::addr() was returning the default implementation (TunnelAddressInfo::Unidentified) when called through pointer types instead of delegating to the underlying concrete type's implementation. The fix adds an addr() method to the blanket TunnelUplink implementation for Deref types that properly delegates to the target type.
- Adds
addr()delegation to the blanketTunnelUplinkimplementation forDereftypes - Ensures that concrete implementations like
QuinnTunnel::addr()are properly called through pointers - Fixes authentication code that was incorrectly capturing
TunnelAddressInfo::Unidentifiedinstead of actual addresses
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iamvamsikrishnad
approved these changes
Nov 25, 2025
harsha-vardhan-2
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TunnelInfo.addr is set in src/common/authentication/traits.perform_authentication using &tunnel.addr(), but unfortunately this returns the result of the default implementation, because the Deref type doesn't have an implementation of addr(). This PR tries to fix that.