Skip to content

Fixed migration of reports with dot in name #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uc-msft merged 2 commits into from
Sep 12, 2022
Merged

Fixed migration of reports with dot in name #1026

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63c453b
Fixed migration of reports with dot in name
v-seradi Jul 6, 2022
44785c6
Corrected variable naming in accordance with comments
v-seradi Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions samples/features/reporting-services/ssrs-migration-rss/ssrs_migration.rss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,21 +948,27 @@ End Function

'Helper function to construct correctly formatted filename
Function GetSnkFilename(srcFilename As String, type As String) As String
Dim hasFE As Boolean = HasFileExtension(srcFilename)
If SnkIsNative And hasFE And Not GetExtension(type) = "" Then 'Cut off file extension, if present
Dim currentFileExtension As String = GetFileNameExtension(srcFilename)

If SnkIsNative And (GetExtension(type) = currentFileExtension) and currentFileExtension <> "" Then 'Cut off file extension, if present
srcFilename = RemoveFileExtension(srcFilename)

ElseIf Not SnkIsNative And Not hasFE Then 'Add file extension, if not present
ElseIf Not SnkIsNative And currentFileExtension = "" Then 'Add file extension, if not present
srcFilename = srcFilename + GetExtension(type)
End If

Return srcFilename
End Function

'Helper
Function HasFileExtension(filename As String) As Boolean
Dim index As Integer = filename.LastIndexOf(".")
Return index >= 0 And filename.Length - index <= 5
Function GetFileNameExtension(filename As String) As String
Dim index as Integer = -1
index = filename.LastIndexOf(".")
If index > 0
Return filename.Substring(index)
Else
Return ""
End If
End Function

'Helper
Expand Down