Skip to content

Initial checkin for hdfs kerberos testing tool#637

Merged
pmasl merged 3 commits intomicrosoft:masterfrom
udlingal:master
Sep 30, 2019
Merged

Initial checkin for hdfs kerberos testing tool#637
pmasl merged 3 commits intomicrosoft:masterfrom
udlingal:master

Conversation

@udlingal
Copy link
Copy Markdown
Contributor

No description provided.

@uc-msft
Copy link
Copy Markdown
Contributor

uc-msft commented Sep 11, 2019

We have a policy of not putting binaries in the samples source. You need to provide the actual code and instructions for how to produce the binary.

@udlingal
Copy link
Copy Markdown
Contributor Author

This is python notebook which uses a jar file. Should I put this in different place under sql-server-samples? Or should I include source code for jar file and python with binaries(this will increase zip file size) in this zip file?

@pmasl
Copy link
Copy Markdown
Contributor

pmasl commented Sep 20, 2019

@udlingal we want to share the Notebook as a whole ready-to-use artifact, but please also add to your PR the source jar and python outside the zip, so that users can see the source. As soon as you do let me know and I can merge.

@udlingal
Copy link
Copy Markdown
Contributor Author

This jar file is derivative of existing hadoopbridge connectors used for PolyBase. as it is still Microsoft propitiatory, we cannot share the code to public yet. can we place just jar files now until we can make the code public access ?

@pmasl pmasl merged commit a26b2f3 into microsoft:master Sep 30, 2019
@pmasl
Copy link
Copy Markdown
Contributor

pmasl commented Sep 30, 2019

Yes, as a sample this is fine for now.

@pmasl
Copy link
Copy Markdown
Contributor

pmasl commented Sep 30, 2019

Please add descriptive header on what the tools does. Also, add the note on co-location requirement to the 1st bullet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants