Skip to content

Conversation

@JonathanZhu11
Copy link
Contributor

@JonathanZhu11 JonathanZhu11 commented Jul 16, 2020

This PR adds Python to the Travis-CI pipeline.

We use the existing tests and run them against the same server as the R tests.

Since this series of tests runs with every check-in, I have removed a few redundant and extremely slow tests. A few tests were originally there to try installing popular ML packages, but most of these ML packages are extremely large and have lots of dependencies. For CI, it is better to test the functionality, so I have trimmed to basic tests.

There are also 2 bug fixes in this PR:

  1. pip moved away from holding pep425tags in their codebase in pip version 20+, so we just import from wheel instead.
  2. The way we resolved requirement specs was not the most robust. We can just use pkg_resources's Requirement class functionality instead of writing our own. In particular, our original implementation did not work with "~=".

@JonathanZhu11 JonathanZhu11 marked this pull request as ready for review July 27, 2020 17:13
@jarupatj
Copy link
Contributor

Can you please clarify in the PR comment on what changes are included in this PR? What test are added. What bug fixes are included?

Address comments and remove some more redundant tests for speed sake
@JonathanZhu11 JonathanZhu11 merged commit 53f42ab into master Aug 7, 2020
@JonathanZhu11 JonathanZhu11 deleted the JonathanZhu11/Travis branch March 15, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants