-
Notifications
You must be signed in to change notification settings - Fork 31
Add Travis CI for Python #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanZhu11
commented
Jul 29, 2020
Contributor
|
Can you please clarify in the PR comment on what changes are included in this PR? What test are added. What bug fixes are included? |
jarupatj
reviewed
Jul 29, 2020
Address comments and remove some more redundant tests for speed sake
jarupatj
approved these changes
Aug 7, 2020
karthikvenkataramaiah
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Python to the Travis-CI pipeline.
We use the existing tests and run them against the same server as the R tests.
Since this series of tests runs with every check-in, I have removed a few redundant and extremely slow tests. A few tests were originally there to try installing popular ML packages, but most of these ML packages are extremely large and have lots of dependencies. For CI, it is better to test the functionality, so I have trimmed to basic tests.
There are also 2 bug fixes in this PR: