Skip to content

Warn during build if generating resources fails#75

Merged
zadjii-msft merged 2 commits intomicrosoft:mainfrom
wangziling:feature/build-process-enhancements
Jul 1, 2024
Merged

Warn during build if generating resources fails#75
zadjii-msft merged 2 commits intomicrosoft:mainfrom
wangziling:feature/build-process-enhancements

Conversation

@wangziling
Copy link
Copy Markdown
Contributor

Add warm notice when failed to execute the build.rs.

If we don't set the -vv flag when executing cargo build, the current command line output will not contain the child_process failures, so that we cannot know why the build process failed.

@wangziling
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this seems fine. Possibly redundant with #86 but valuable nonetheless. Thanks!

@zadjii-msft zadjii-msft changed the title Build process enhancements Warn during build if generating resources fails Jul 1, 2024
@zadjii-msft zadjii-msft merged commit 5fd6a79 into microsoft:main Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants