refactor(bundle-size): convert API classes to factory functions (PR 7/14)#544
Open
layershifter wants to merge 15 commits into
Open
refactor(bundle-size): convert API classes to factory functions (PR 7/14)#544layershifter wants to merge 15 commits into
layershifter wants to merge 15 commits into
Conversation
\`patch-package\` postinstall hook applies three changes to keyborg@2.14.0 covering both the ESM (\`dist/index.js\`) and CJS (\`dist/index.cjs\`) bundles: 1. \`event.details = details\` — drop the \`@deprecated\` alias of \`event.detail\`. Tabster reads \`e.detail\` exclusively (verified across src/State/FocusedElement.ts and the rest of the codebase). 2. \`triggerKeys\` / \`dismissKeys\` props + the supporting \`shouldDismiss\` / \`scheduleDismiss\` / \`dismissTimer\` machinery. Tabster only ever calls \`createKeyborg(getWindow())\` with no props. 3. \`canOverrideNativeFocus\` runtime probe. Replaces the \`_canOverrideNativeFocus\` flag with the implicit-true assumption modern browsers (everything since IE9) already satisfy. The conditional \`details.isFocusedProgrammatically\` write becomes unconditional — semantically identical when override works. Bundle deltas (createTabster default-mode): keyborg slice: 3.71 → 3.12 kB (-590 B, -16%) createTabster: 30.78 → 30.18 kB (-600 B) getModalizer: 38.47 → 37.87 kB (-600 B) getMover: 44.54 → 43.94 kB (-600 B) getCrossOrigin: 89.64 → 89.04 kB (-600 B) allExports: 92.09 → 91.50 kB (-590 B) Tests pass: 3 pre-existing failures, no regressions across default, uncontrolled, and root-dummy-inputs modes. Stop-gap until upstream microsoft/keyborg can release the same trims (the changes belong there, not as a Tabster-side fork). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Converts the `Subscribable<A, B>` abstract class and its consumers to factory functions returning plain objects. - `Subscribable` → `createSubscribable<A,B>()` factory returning a `SubscribableCore` interface. The public surface (subscribe/ subscribeFirst/unsubscribe) matches `Types.Subscribable`; setVal/ getVal/trigger are exposed for the composing factory only. - `KeyboardNavigationState` class → `createKeyboardNavigationState` factory. - `FocusedElementState` class → `createFocusedElementState` factory. `FocusedElementState` is preserved as a const namespace for the `forgetMemorized` and `findNextTabbable` static helpers. - `ObservedElementAPI` class → `createObservedElementAPI` factory. - `CrossOriginFocusedElementState` class → `createCrossOriginFocusedElementState` factory, with `setVal` static kept under same-named const namespace. - `CrossOriginObservedElementState` class → `createCrossOriginObservedElementState` factory, with `trigger` static kept under same-named const namespace. Also trims `Subscribable` itself: drops the `callCallbacks` helper in favour of the inlined `trigger` closure, and adds `declare` to `TabsterCustomEvent.details` to drop the redundant initializer SWC was emitting. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
DummyInput was 23.6% of the core bundle (the single largest module).
Converting the four classes here in one coordinated pass:
- DummyInput → createDummyInput
- DummyInputManager → createDummyInputManager (interface + factory),
with externally-used statics moveWithPhantomDummy
and addPhantomDummyWithTarget kept under a same-
named const namespace
- DummyInputManagerCore → createDummyInputManagerCore. The class's
constructor-return-existing-instance trick (used
when an element already has dummy inputs from
another subsystem) becomes a natural early-return
in a factory.
- DummyInputObserver → createDummyInputObserver
The four DummyManager subclasses (RootDummyManager, ModalizerDummyManager,
MoverDummyManager, GroupperDummyManager) are migrated from `extends
DummyInputManager` to composing `createDummyInputManager` and calling
`manager.setHandlers(...)` directly. They become free functions
(createRootDummyManager etc.) returning the same DummyInputManager
interface, so the consuming `dummyManager` field on Root/Modalizer/Mover/
Groupper is now typed as the interface rather than the subclass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Class scaffolding (constructor + private field declarations + this-binding on arrow methods) doesn't mangle as well as plain top-level functions and closures. Switching RestorerAPI to a factory shaves ~570 B minified / ~45 B gzipped on getRestorer. Pattern: closures replace private fields; the returned object exposes only the public methods the interface requires. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Static methods (getDeloser, getHistory, forceRestoreFocus) are kept under a same-named const namespace, so external call sites in CrossOrigin.ts continue to work unchanged. The internal state needed by those statics is exposed via an internal interface with _-prefixed accessors. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…actory conversions Apply post-cherry-pick fixes across all 8 converted API factories: - Use addListener/removeListener helpers (PR4) instead of direct addEventListener - Use focusedElementState method calls instead of missing free-function exports - Expose _grouppers/_modalizers as internal getters for test compatibility - Add _grouppers and _modalizers to GroupperAPIInternal/ModalizerAPIInternal types - Exclude generated bundle-size/.readable/ and .claude/ from prettier checks Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
📊 Bundle size report
🤖 This report was generated against a579ebbd50e37f1565551549fe57bbc9ddafab64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 7 of 14 in the bundle-size refactor stack (
refactor/api-factories). Converts 8 remaining API classes to factory functions, completing the class→factory migration for all public API objects:RestorerAPI→createRestorerAPIOutlineAPI→createOutlineAPIDeloserAPI→createDeloserAPI(keepsDeloserAPInamespace for statics)GroupperAPI→createGroupperAPIMoverAPI→createMoverAPIModalizerAPI→createModalizerAPICrossOriginAPI→createCrossOriginAPIUncontrolledAPI→createUncontrolledAPIDepends on PR 6 (
chore/bundle-size-stack-6, DummyInput factory), PR 5 (Subscribable/CrossOrigin state factories), and PR 4 (event/timer helper functions).Test plan
npm run type-checkpassesnpm run lint:checkpassesnpm run format:checkpassesnpm run testpasses (286 tests, 18 skipped, 0 failures)🤖 Generated with Claude Code