Skip to content

Revert Targeted Messages support (PR #195 and #222)#290

Merged
ShanmathiMayuramKrithivasan merged 2 commits intomicrosoft:mainfrom
ShanmathiMayuramKrithivasan:shmayura/revert-targeted-messages
Jan 30, 2026
Merged

Revert Targeted Messages support (PR #195 and #222)#290
ShanmathiMayuramKrithivasan merged 2 commits intomicrosoft:mainfrom
ShanmathiMayuramKrithivasan:shmayura/revert-targeted-messages

Conversation

@ShanmathiMayuramKrithivasan
Copy link
Copy Markdown
Collaborator

Revert Targeted Messages support (PR #195 and #222)

This reverts the following PRs:

Removes the isTargeted parameter from all Send/Reply APIs.

Copilot AI review requested due to automatic review settings January 28, 2026 10:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleanly reverts the targeted messages support that was introduced in PRs #195 and #222. It removes the isTargeted boolean parameter from all Send/Reply APIs across the codebase, eliminating the ability to send messages privately to specific recipients within a conversation.

Changes:

  • Removed isTargeted parameter from all Send, Reply, Update, Create, and Delete methods across the API surface
  • Removed conditional logic for appending isTargetedActivity=true query parameter to API URLs
  • Removed validation logic that required activity.Recipient for targeted messages
  • Removed test coverage for targeted message scenarios

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Libraries/Microsoft.Teams.Api/Clients/ActivityClient.cs Removed isTargeted parameter from CreateAsync, UpdateAsync, ReplyAsync, and DeleteAsync methods; removed query parameter logic
Tests/Microsoft.Teams.Api.Tests/Clients/ActivityClientTests.cs Removed four test methods for targeted message scenarios
Libraries/Microsoft.Teams.Apps/Plugins/SenderPlugin.cs Removed interface method overloads with isTargeted parameter
Libraries/Microsoft.Teams.Plugins/Microsoft.Teams.Plugins.AspNetCore/AspNetCorePlugin.cs Removed Send method overloads with isTargeted parameter and updated all call sites
Libraries/Microsoft.Teams.Apps/App.cs Removed isTargeted parameter from Send methods, removed recipient validation, removed User field assignment in ConversationReference
Libraries/Microsoft.Teams.Apps/Contexts/Context.Send.cs Removed isTargeted parameter from all Send/Reply methods in interface and implementation, removed related documentation
Libraries/Microsoft.Teams.Apps/Contexts/Context.Client.cs Removed isTargeted parameter from Client class methods and removed related documentation
Libraries/Microsoft.Teams.Apps/Contexts/Context.SignIn.cs Removed explicit isTargeted: false arguments from Send calls
Libraries/Microsoft.Teams.Apps.Testing/Plugins/TestPlugin.cs Removed Send method overloads with isTargeted parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ShanmathiMayuramKrithivasan ShanmathiMayuramKrithivasan merged commit 8253df1 into microsoft:main Jan 30, 2026
6 checks passed
ShanmathiMayuramKrithivasan added a commit to ShanmathiMayuramKrithivasan/teams.net that referenced this pull request Mar 10, 2026
…microsoft#290)

Revert Targeted Messages support (PR microsoft#195 and microsoft#222)

This reverts the following PRs:
- [PR microsoft#222](microsoft#222): Fix App
Send Targeted Messages (5c40750)
- [PR microsoft#195](microsoft#195): Add
support for Targeted Messages (98502aa)

Removes the isTargeted parameter from all Send/Reply APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants