Revert Targeted Messages support (PR #195 and #222)#290
Merged
ShanmathiMayuramKrithivasan merged 2 commits intomicrosoft:mainfrom Jan 30, 2026
Conversation
Copilot started reviewing on behalf of
ShanmathiMayuramKrithivasan
January 28, 2026 10:26
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleanly reverts the targeted messages support that was introduced in PRs #195 and #222. It removes the isTargeted boolean parameter from all Send/Reply APIs across the codebase, eliminating the ability to send messages privately to specific recipients within a conversation.
Changes:
- Removed
isTargetedparameter from all Send, Reply, Update, Create, and Delete methods across the API surface - Removed conditional logic for appending
isTargetedActivity=truequery parameter to API URLs - Removed validation logic that required
activity.Recipientfor targeted messages - Removed test coverage for targeted message scenarios
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Libraries/Microsoft.Teams.Api/Clients/ActivityClient.cs | Removed isTargeted parameter from CreateAsync, UpdateAsync, ReplyAsync, and DeleteAsync methods; removed query parameter logic |
| Tests/Microsoft.Teams.Api.Tests/Clients/ActivityClientTests.cs | Removed four test methods for targeted message scenarios |
| Libraries/Microsoft.Teams.Apps/Plugins/SenderPlugin.cs | Removed interface method overloads with isTargeted parameter |
| Libraries/Microsoft.Teams.Plugins/Microsoft.Teams.Plugins.AspNetCore/AspNetCorePlugin.cs | Removed Send method overloads with isTargeted parameter and updated all call sites |
| Libraries/Microsoft.Teams.Apps/App.cs | Removed isTargeted parameter from Send methods, removed recipient validation, removed User field assignment in ConversationReference |
| Libraries/Microsoft.Teams.Apps/Contexts/Context.Send.cs | Removed isTargeted parameter from all Send/Reply methods in interface and implementation, removed related documentation |
| Libraries/Microsoft.Teams.Apps/Contexts/Context.Client.cs | Removed isTargeted parameter from Client class methods and removed related documentation |
| Libraries/Microsoft.Teams.Apps/Contexts/Context.SignIn.cs | Removed explicit isTargeted: false arguments from Send calls |
| Libraries/Microsoft.Teams.Apps.Testing/Plugins/TestPlugin.cs | Removed Send method overloads with isTargeted parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
singhk97
approved these changes
Jan 29, 2026
ShanmathiMayuramKrithivasan
added a commit
to ShanmathiMayuramKrithivasan/teams.net
that referenced
this pull request
Mar 10, 2026
…microsoft#290) Revert Targeted Messages support (PR microsoft#195 and microsoft#222) This reverts the following PRs: - [PR microsoft#222](microsoft#222): Fix App Send Targeted Messages (5c40750) - [PR microsoft#195](microsoft#195): Add support for Targeted Messages (98502aa) Removes the isTargeted parameter from all Send/Reply APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert Targeted Messages support (PR #195 and #222)
This reverts the following PRs:
Removes the isTargeted parameter from all Send/Reply APIs.