Git Ignore launchSettings and appsettings.Development#298
Conversation
- Add Microsoft.Teams logging section with info level - Add Teams section with TenantId, ClientId, and ClientSecret placeholders - Remove AllowedHosts, OpenAI, and legacy Teams settings - Clean up and streamline configuration structure
There was a problem hiding this comment.
Pull request overview
This PR streamlines configuration across the sample projects by removing development-only config/launch files, standardizing Teams config fields, and aligning Teams logging defaults.
Changes:
- Removed tracked
appsettings.Development.jsonandProperties/launchSettings.jsonfrom samples, addinglaunchSettings.TEMPLATE.jsonas a starting point. - Standardized
Logging:Microsoft.Teamslevel to"info"and ensured a consistentTeamsconfig shape (includingTenantId). - Updated
.gitignoreto ignore development appsettings and launch settings.
Reviewed changes
Copilot reviewed 47 out of 48 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Samples/Samples.Tab/appsettings.json | Adjust Teams logging level and add Teams:TenantId; remove AllowedHosts. |
| Samples/Samples.Tab/appsettings.Development.json | Remove development-specific config file. |
| Samples/Samples.Tab/Properties/launchSettings.json | Remove tracked launch settings. |
| Samples/Samples.Tab/Properties/launchSettings.TEMPLATE.json | Add template launch settings with Teams env vars. |
| Samples/Samples.MessageExtensions/appsettings.json | Add Teams logging section and Teams:TenantId; remove AllowedHosts. |
| Samples/Samples.MessageExtensions/appsettings.Development.json | Remove development-specific config file. |
| Samples/Samples.MessageExtensions/Properties/launchSettings.json | Remove tracked launch settings. |
| Samples/Samples.MessageExtensions/Properties/launchSettings.TEMPLATE.json | Add template launch settings with Teams env vars. |
| Samples/Samples.Meetings/appsettings.json | Add Teams logging section; normalize Teams section (fix TenantId placement); remove AllowedHosts. |
| Samples/Samples.Meetings/Properties/launchSettings.TEMPLATE.json | Add template launch settings with Teams env vars. |
| Samples/Samples.McpClient/appsettings.json | Add Teams logging section and Teams section; remove AllowedHosts. |
| Samples/Samples.McpClient/appsettings.Development.json | Remove development-specific config (previously contained OpenAI config). |
| Samples/Samples.McpClient/Properties/launchSettings.json | Remove tracked launch settings. |
| Samples/Samples.McpClient/Properties/launchSettings.TEMPLATE.json | Add template launch settings with Teams env vars. |
| Samples/Samples.Mcp/appsettings.json | Adjust Teams logging level and add Teams:TenantId; remove AllowedHosts. |
| Samples/Samples.Mcp/appsettings.Development.json | Remove development-specific config file. |
| Samples/Samples.Mcp/Properties/launchSettings.json | Remove tracked launch settings. |
| Samples/Samples.Mcp/Properties/launchSettings.TEMPLATE.json | Add template launch settings with Teams env vars. |
| Samples/Samples.Lights/appsettings.json | Adjust Teams logging level and add Teams:TenantId; keep OpenAI section; remove AllowedHosts. |
| Samples/Samples.Lights/appsettings.Development.json | Remove development-specific config file. |
| Samples/Samples.Lights/Properties/launchSettings.json | Remove tracked launch settings. |
| Samples/Samples.Lights/Properties/launchSettings.TEMPLATE.json | Add template launch settings including Teams + OpenAI env vars. |
| Samples/Samples.Graph/appsettings.json | Adjust Teams logging level and add Teams:TenantId; remove AllowedHosts. |
| Samples/Samples.Graph/appsettings.Development.json | Remove development-specific config file. |
| Samples/Samples.Graph/Properties/launchSettings.json | Remove tracked launch settings. |
| Samples/Samples.Graph/Properties/launchSettings.TEMPLATE.json | Add template launch settings with Teams env vars. |
| Samples/Samples.Echo/appsettings.json | Adjust Teams logging level and add Teams:TenantId; remove AllowedHosts. |
| Samples/Samples.Echo/appsettings.Development.json | Remove development-specific config file. |
| Samples/Samples.Echo/Properties/launchSettings.json | Remove tracked launch settings. |
| Samples/Samples.Echo/Properties/launchSettings.TEMPLATE.json | Add template launch settings with Teams env vars. |
| Samples/Samples.Dialogs/appsettings.json | Add Teams logging section and Teams:TenantId; remove AllowedHosts. |
| Samples/Samples.Dialogs/appsettings.Development.json | Remove development-specific config file (included BotEndpoint placeholder). |
| Samples/Samples.Dialogs/Properties/launchSettings.json | Remove tracked launch settings. |
| Samples/Samples.Dialogs/Properties/launchSettings.TEMPLATE.json | Rename profile and add Teams env vars; normalize env to Development. |
| Samples/Samples.Cards/appsettings.json | Add Teams logging section and Teams:TenantId; remove AllowedHosts. |
| Samples/Samples.Cards/appsettings.Development.json | Remove development-specific config file. |
| Samples/Samples.Cards/Properties/launchSettings.TEMPLATE.json | Rename profile and add Teams env vars; normalize env to Development. |
| Samples/Samples.BotBuilder/appsettings.json | Adjust Teams logging level; remove AllowedHosts and Teams section; keep MicrosoftApp settings. |
| Samples/Samples.BotBuilder/appsettings.Development.json | Remove development-specific config file. |
| Samples/Samples.BotBuilder/Properties/launchSettings.TEMPLATE.json | Add template launch settings with MicrosoftApp env vars. |
| Samples/Samples.AI/appsettings.json | Add Teams logging + Teams section; remove AllowedHosts. |
| Samples/Samples.AI/appsettings.Development.json | Remove development-specific config (previously contained Azure OpenAI config). |
| Samples/Samples.AI/Properties/launchSettings.TEMPLATE.json | Rename profile and add Teams env vars; normalize env to Development. |
| Samples/Deprecated.Controllers/appsettings.json | Add Teams logging section and Teams credentials section; remove AllowedHosts. |
| Samples/Deprecated.Controllers/appsettings.Development.json | Remove development-specific config file. |
| Samples/Deprecated.Controllers/Properties/launchSettings.json | Remove tracked launch settings. |
| Samples/Deprecated.Controllers/Properties/launchSettings.TEMPLATE.json | Rename profile and add Teams env vars; normalize env to Development. |
| .gitignore | Ignore development appsettings and launch settings (but casing needs adjustment). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 48 out of 49 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The launchSettings.json file was deleted. It previously defined local development settings, including the application URL and environment variables for running the project. This change removes those local launch configurations.
Added OpenAI__ApiKey and OpenAI__Model environment variables to launchSettings.TEMPLATE.json for OpenAI integration. Also replaced or corrected the template file with a version including $schema and a single "http" profile for improved standardization.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 50 out of 51 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request updates configuration files across multiple sample projects to streamline settings and improve consistency. The main changes include removing development-specific configuration and launch settings files, updating logging levels, and standardizing Teams-related configuration fields in the main `appsettings.json` files. **Configuration cleanup and simplification:** * Removed all `appsettings.Development.json` files from sample projects to reduce redundancy and potential confusion between environments. [[1]](diffhunk://#diff-5439b95ce389013d33ee448a25be2878a6dd9218522b6814f69373c5a5f37975L1-L15) [[2]](diffhunk://#diff-e30c9cce15f0322c962681d558e51870fdeb2abf7dc4d598af1b8142f063cab5L1-L20) [[3]](diffhunk://#diff-ba85b9b96e11104b6c9e0e82ddf2aec9019051c614a2a251f16df6cf0e2e7fb7L1-L16) [[4]](diffhunk://#diff-ca0bf0e5331d6d35f4e656f8230521df028678e065438985bce2fe4062b416e1L1-L17) [[5]](diffhunk://#diff-2693161e51a2890a939c3b50a513fdba1fbc9cf501921db3a24e359e8ec58107L1-L17) [[6]](diffhunk://#diff-ddc8854b36950fca8d32941e6ce48a2d2d90047e83e92835f3c87f579290870aL1-L12) * Deleted all `launchSettings.json` files from the `Properties` folders of sample projects, simplifying project startup configuration. [[1]](diffhunk://#diff-df03406aed8846b4a9d367ea99464d6ad0fff57883bb992c4e2b30077c0a749bL1-L14) [[2]](diffhunk://#diff-15e178976322d0652b9210c1fa7b633388c82e58f318e82a427863a3f4812721L1-L15) **Logging and Teams configuration standardization:** * Updated the `Microsoft.Teams` logging level from `"debug"` to `"info"` in all `appsettings.json` files for consistency, and added or standardized the `Enable` property. [[1]](diffhunk://#diff-1bf7a48b908c94fa2249e41fa85a1406d1dec0a7229dbb65b3e0ad93f4f5f9b6L9-R15) [[2]](diffhunk://#diff-bb20d2fb788efcde359dda566fe30442bd9b4e3d98a189be8e027df064d1d725L9-R16) [[3]](diffhunk://#diff-053ffab9386ea0b28b1a2b0047c6a97b768c0ee18bc2761f5c44700ffd2eda32R6-R16) * Unified the `Teams` configuration section in `appsettings.json` across samples by adding `TenantId` and ensuring all relevant fields are present. [[1]](diffhunk://#diff-053ffab9386ea0b28b1a2b0047c6a97b768c0ee18bc2761f5c44700ffd2eda32R6-R16) [[2]](diffhunk://#diff-bb20d2fb788efcde359dda566fe30442bd9b4e3d98a189be8e027df064d1d725L9-R16) **General configuration cleanup:** * Removed the `AllowedHosts` property from `appsettings.json` files where it was previously included, as it is not needed for these samples. [[1]](diffhunk://#diff-053ffab9386ea0b28b1a2b0047c6a97b768c0ee18bc2761f5c44700ffd2eda32R6-R16) [[2]](diffhunk://#diff-bb20d2fb788efcde359dda566fe30442bd9b4e3d98a189be8e027df064d1d725L9-R16) [[3]](diffhunk://#diff-1bf7a48b908c94fa2249e41fa85a1406d1dec0a7229dbb65b3e0ad93f4f5f9b6L9-R15) These changes help ensure that sample projects are easier to configure, maintain, and understand.
This pull request updates configuration files across multiple sample projects to streamline settings and improve consistency. The main changes include removing development-specific configuration and launch settings files, updating logging levels, and standardizing Teams-related configuration fields in the main
appsettings.jsonfiles.Configuration cleanup and simplification:
appsettings.Development.jsonfiles from sample projects to reduce redundancy and potential confusion between environments. [1] [2] [3] [4] [5] [6]launchSettings.jsonfiles from thePropertiesfolders of sample projects, simplifying project startup configuration. [1] [2]Logging and Teams configuration standardization:
Microsoft.Teamslogging level from"debug"to"info"in allappsettings.jsonfiles for consistency, and added or standardized theEnableproperty. [1] [2] [3]Teamsconfiguration section inappsettings.jsonacross samples by addingTenantIdand ensuring all relevant fields are present. [1] [2]General configuration cleanup:
AllowedHostsproperty fromappsettings.jsonfiles where it was previously included, as it is not needed for these samples. [1] [2] [3]These changes help ensure that sample projects are easier to configure, maintain, and understand.