Routing: run all handlers sequentially and add startup validation #343
Merged
MehakBindra merged 12 commits intonext/corefrom Feb 27, 2026
Merged
Routing: run all handlers sequentially and add startup validation #343MehakBindra merged 12 commits intonext/corefrom
MehakBindra merged 12 commits intonext/corefrom
Conversation
rido-min
approved these changes
Feb 23, 2026
rido-min
reviewed
Feb 23, 2026
rido-min
reviewed
Feb 23, 2026
rido-min
reviewed
Feb 23, 2026
corinagum
reviewed
Feb 23, 2026
corinagum
reviewed
Feb 23, 2026
corinagum
reviewed
Feb 23, 2026
corinagum
reviewed
Feb 23, 2026
Contributor
|
First: I think running all matching handlers sequentially is the right call. I'm leaving this as a non-blocking comment: I'm reallly hesitant about removing the middleware chain. What we're sacrificing by getting rid of
|
corinagum
requested changes
Feb 23, 2026
Contributor
corinagum
left a comment
There was a problem hiding this comment.
I'm very hesitant about this one. Will leave some comments in Teams.
corinagum
approved these changes
Feb 24, 2026
singhk97
approved these changes
Feb 25, 2026
Collaborator
singhk97
left a comment
There was a problem hiding this comment.
one nit: but looks good to me otherwise
auto-merge was automatically disabled
February 27, 2026 01:16
Repository rule violations found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registration order is preserved.
exceptions instead of logging.